[webkit-changes] [WebKit/WebKit] cb302c: [webkitpy] Move WebKitFinder.{layout, perf}_tests_d...

[Sam Sneddon]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cb302cd1f44f09c8b330f4c25efb99347b3b8878
      https://github.com/WebKit/WebKit/commit/cb302cd1f44f09c8b330f4c25efb99347b3b8878
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
    M Tools/Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py
    M Tools/Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py
    M Tools/Scripts/webkitpy/common/webkit_finder.py
    M Tools/Scripts/webkitpy/port/base.py
    M Tools/Scripts/webkitpy/w3c/test_downloader.py
    M Tools/Scripts/webkitpy/w3c/test_importer.py
    M Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

  Log Message:
  -----------
  [webkitpy] Move WebKitFinder.{layout,perf}_tests_dir to Port
https://bugs.webkit.org/show_bug.cgi?id=264750

Reviewed by Jonathan Bedard.

We currently have two copies of these methods: one on the WebKitFinder
and one on the Port. The version on the Port allow the layout test
directory to be overriden by --layout-tests-dir (which is used for
certain non-public tests, for example).

We don't want to ever end up calling a code path that doesn't obey that
option if it has been passed, so it makes sense to unify all calls onto
the variants on Port.

To achieve this, we have to adjust a number of call sites to actually
have a Port, but this is a surprisingly small number.

* Tools/Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py:
(TestExpectationUpdater.__init__):
(main):
* Tools/Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py:
(TestExpectationUpdaterTest.test_update_test_expectations):
* Tools/Scripts/webkitpy/common/webkit_finder.py:
(WebKitFinder.path_from_webkit_base):
(WebKitFinder.path_to_script):
(WebKitFinder.layout_tests_dir): Deleted.
(WebKitFinder.perf_tests_dir): Deleted.
* Tools/Scripts/webkitpy/port/base.py:
(Port.path_from_webkit_base):
(Port.layout_tests_dir):
(Port.perf_tests_dir):
* Tools/Scripts/webkitpy/w3c/test_downloader.py:
(TestDownloader.__init__):
* Tools/Scripts/webkitpy/w3c/test_importer.py:
(main):
(TestImporter.__init__):
(TestImporter.test_downloader):
* Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:
(TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
(TestImporterTest.test_import_dir_with_no_tests):
(TestImporterTest.test_import_dir_with_empty_init_py):
(TestImporterTest.import_directory):
(TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
(TestImporterTest.import_downloaded_tests):

Canonical link: https://commits.webkit.org/270880@main