[webkit-changes] [WebKit/WebKit] 114aa2: AX: NSAccessibilityUIElementCountForSearchPredicat...

Tyler Wilcock noreply at github.com
Fri Nov 17 01:15:57 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 114aa2c8594807cbc34dd5dff48a9e2addfd1e00
      https://github.com/WebKit/WebKit/commit/114aa2c8594807cbc34dd5dff48a9e2addfd1e00
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
    M LayoutTests/accessibility/mac/bounds-for-range-expected.txt
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
    M Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
    M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm

  Log Message:
  -----------
  AX: NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute is not used by any AT
https://bugs.webkit.org/show_bug.cgi?id=265004
rdar://118546456

Reviewed by Chris Fleizach.

This was added in https://bugs.webkit.org/show_bug.cgi?id=124561, but isn't by any assistive technology anymore.
This patch removes it.

There are some tests that use uiElementCountForSearchPredicate to count the number of objects of certain types,
and we probably want to keep these test conditions. So this patch reimplements this function in terms of AXUIElementsForSearchPredicate,
which is heavily used by VoiceOver, and just counts the results.

* LayoutTests/accessibility/mac/bounds-for-range-expected.txt:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
* Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::uiElementCountForSearchPredicate):
* Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):

Canonical link: https://commits.webkit.org/270872@main




More information about the webkit-changes mailing list