[webkit-changes] [WebKit/WebKit] 4fb442: Cleanup RenderTheme a bit

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4fb442b35993f278b3aed472c79779f35e6da174
      https://github.com/WebKit/WebKit/commit/4fb442b35993f278b3aed472c79779f35e6da174
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-11-17 (Fri, 17 Nov 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderTheme.cpp
    M Source/WebCore/rendering/RenderTheme.h

  Log Message:
  -----------
  Cleanup RenderTheme a bit
https://bugs.webkit.org/show_bug.cgi?id=264866

Reviewed by Tim Horton.

This makes the following changes:

- Inline (near-)empty methods into the header to reduce clutter.
- Remove setCheckboxSize, setRadioSize, adjustInnerSpinButtonStyle, and
  paintInnerSpinButton as no theme customizes them.
- Remove some comments referring to a browser we no longer compare
  against.
- Add some #endif comments for clarity.

* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::adjustCheckboxStyle const):
(WebCore::RenderTheme::adjustRadioStyle const):
(WebCore::RenderTheme::adjustButtonStyle const): Deleted.
(WebCore::RenderTheme::adjustInnerSpinButtonStyle const): Deleted.
(WebCore::RenderTheme::adjustTextFieldStyle const): Deleted.
(WebCore::RenderTheme::adjustTextAreaStyle const): Deleted.
(WebCore::RenderTheme::supportsMeter const): Deleted.
(WebCore::RenderTheme::paintMeter): Deleted.
(WebCore::RenderTheme::adjustCapsLockIndicatorStyle const): Deleted.
(WebCore::RenderTheme::paintCapsLockIndicator): Deleted.
(WebCore::RenderTheme::paintAttachment): Deleted.
(WebCore::RenderTheme::adjustListButtonStyle const): Deleted.
(WebCore::RenderTheme::sliderTickSnappingThreshold const): Deleted.
(WebCore::RenderTheme::adjustImageControlsButtonStyle const): Deleted.
(WebCore::RenderTheme::adjustProgressBarStyle const): Deleted.
(WebCore::RenderTheme::shouldHaveCapsLockIndicator const): Deleted.
(WebCore::RenderTheme::adjustMenuListButtonStyle const): Deleted.
(WebCore::RenderTheme::adjustSliderTrackStyle const): Deleted.
(WebCore::RenderTheme::adjustSliderThumbSize const): Deleted.
(WebCore::RenderTheme::adjustSearchFieldStyle const): Deleted.
(WebCore::RenderTheme::adjustSearchFieldCancelButtonStyle const): Deleted.
(WebCore::RenderTheme::adjustSearchFieldDecorationPartStyle const): Deleted.
(WebCore::RenderTheme::adjustSearchFieldResultsDecorationPartStyle const): Deleted.
(WebCore::RenderTheme::adjustSearchFieldResultsButtonStyle const): Deleted.
* Source/WebCore/rendering/RenderTheme.h:
(WebCore::RenderTheme::adjustSliderThumbSize const):
(WebCore::RenderTheme::supportsMeter const):
(WebCore::RenderTheme::sliderTickSnappingThreshold const):
(WebCore::RenderTheme::shouldHaveCapsLockIndicator const):
(WebCore::RenderTheme::paintCheckbox):
(WebCore::RenderTheme::paintRadio):
(WebCore::RenderTheme::adjustButtonStyle const):
(WebCore::RenderTheme::adjustTextFieldStyle const):
(WebCore::RenderTheme::adjustTextAreaStyle const):
(WebCore::RenderTheme::adjustMenuListButtonStyle const):
(WebCore::RenderTheme::paintMeter):
(WebCore::RenderTheme::adjustCapsLockIndicatorStyle const):
(WebCore::RenderTheme::paintCapsLockIndicator):
(WebCore::RenderTheme::paintAttachment):
(WebCore::RenderTheme::adjustListButtonStyle const):
(WebCore::RenderTheme::adjustImageControlsButtonStyle const):
(WebCore::RenderTheme::adjustProgressBarStyle const):
(WebCore::RenderTheme::adjustSliderTrackStyle const):
(WebCore::RenderTheme::adjustSearchFieldStyle const):
(WebCore::RenderTheme::adjustSearchFieldCancelButtonStyle const):
(WebCore::RenderTheme::adjustSearchFieldDecorationPartStyle const):
(WebCore::RenderTheme::adjustSearchFieldResultsDecorationPartStyle const):
(WebCore::RenderTheme::adjustSearchFieldResultsButtonStyle const):
(WebCore::RenderTheme::setCheckboxSize const): Deleted.
(WebCore::RenderTheme::setRadioSize const): Deleted.
(WebCore::RenderTheme::paintInnerSpinButton): Deleted.

Canonical link: https://commits.webkit.org/270871@main