[webkit-changes] [WebKit/WebKit] d53d6d: Move enums under WebCore/rendering/ to use the ser...

Mikhail R. Gadelha noreply at github.com
Sun Nov 12 12:23:00 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d53d6d23b888ad7f49bd058a9d8e233983e40f07
      https://github.com/WebKit/WebKit/commit/d53d6d23b888ad7f49bd058a9d8e233983e40f07
  Author: Mikhail R. Gadelha <mikhail at igalia.com>
  Date:   2023-11-12 (Sun, 12 Nov 2023)

  Changed paths:
    M Source/WebCore/page/LocalFrameView.cpp
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/rendering/Pagination.h
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderObject.h
    M Source/WebCore/rendering/RenderView.cpp
    M Source/WebCore/rendering/style/RenderStyle.cpp
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGForeignObject.cpp
    M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResource.h
    M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.h
    M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceMasker.h
    M Source/WebCore/style/StyleResolveForDocument.cpp
    M Source/WebCore/testing/Internals.cpp
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/UIProcess/API/C/WKPage.cpp
    M Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
    M Source/WebKitLegacy/mac/WebView/WebView.mm

  Log Message:
  -----------
  Move enums under WebCore/rendering/ to use the serializer
https://bugs.webkit.org/show_bug.cgi?id=264623

Reviewed by Chris Dumez.

This patch covers the enums in Pagination.h (WebCore::PaginationMode) and
in RenderObject.h (WebCore::RepaintRectCalculation).

The patch mostly just adds the necessary scopes given that the enums now
are enum classes. The only exception is the EnumeratedArray in the
rendering/svg/legacy/ headers, which needed an extra argument, the last
value in the enum; without it EnumeratedArray tries to call
EnumTraits<Key>::values::max> and fails

* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::paginationModeForRenderStyle):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::pageCount const):
(WebCore::Page::pageCountAssumingLayoutIsUpToDate const):
* Source/WebCore/rendering/Pagination.h:
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::checkForPaginationLogicalHeightChange):
* Source/WebCore/rendering/RenderObject.h:
* Source/WebCore/rendering/RenderView.cpp:
(WebCore::RenderView::styleDidChange):
(WebCore::RenderView::requiresColumns const):
(WebCore::RenderView::paint):
(WebCore::RenderView::pageNumberForBlockProgressionOffset const):
(WebCore::RenderView::pageCount const):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setColumnStylesFromPaginationMode):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGForeignObject.cpp:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResource.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceMasker.h:
* Source/WebCore/style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::setPagination):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/API/C/WKPage.cpp:
(WKPageSetPaginationMode):
(WKPageGetPaginationMode):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setPaginationMode):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:

Canonical link: https://commits.webkit.org/270613@main




More information about the webkit-changes mailing list