[webkit-changes] [WebKit/WebKit] 723ded: [WPE][GTK][Debug] Crashes in imported/w3c/web-plat...

Philippe Normand noreply at github.com
Sun Nov 12 11:13:01 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 723ded32d95eedc80be4ba1b3bc66c5e245da795
      https://github.com/WebKit/WebKit/commit/723ded32d95eedc80be4ba1b3bc66c5e245da795
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-11-12 (Sun, 12 Nov 2023)

  Changed paths:
    M Source/WebCore/Modules/reporting/ReportingScope.cpp

  Log Message:
  -----------
  [WPE][GTK][Debug] Crashes in imported/w3c/web-platform-tests/reporting
https://bugs.webkit.org/show_bug.cgi?id=264709

Reviewed by Michael Catanzaro.

The C++ standard doesn't define an order of evaluation for function arguments, so without forcing it
when creating the report we might trigger a use-after-move. This was specially noticeable on GCC
builds, not so much with clang.

* Source/WebCore/Modules/reporting/ReportingScope.cpp:
(WebCore::ReportingScope::generateTestReport):

Canonical link: https://commits.webkit.org/270612@main




More information about the webkit-changes mailing list