[webkit-changes] [WebKit/WebKit] cc3029: [macOS] Fix appearance of text inputs with a datal...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cc302941e056d54f5b44e93694addf4512c63c1a
      https://github.com/WebKit/WebKit/commit/cc302941e056d54f5b44e93694addf4512c63c1a
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2023-11-07 (Tue, 07 Nov 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/mac/controls/ControlMac.mm
    M Source/WebKit/UIProcess/mac/WebDataListSuggestionsDropdownMac.mm

  Log Message:
  -----------
  [macOS] Fix appearance of text inputs with a datalist in vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=264351
rdar://118066878

Reviewed by Tim Horton.

There are currently two issues with text inputs + <datalist> in vertical
writing mode:

1. Dropdown indicator is positioned incorrectly – the indicator is still vertically centered.
2. Dropdown menu is extremely narrow – the menu uses the width rather than the inline size.

Fix (1) by re-writing painting code to use logical coordinates. Fix (2) by using the larger
of element width and height to size the menu.

* Source/WebCore/platform/graphics/mac/controls/ControlMac.mm:
(WebCore::ControlMac::drawListButton):
* Source/WebKit/UIProcess/mac/WebDataListSuggestionsDropdownMac.mm:
(-[WKDataListSuggestionsController dropdownRectForElementRect:]):

Canonical link: https://commits.webkit.org/270356@main