[webkit-changes] [WebKit/WebKit] 1ce253: [iOS] Range inputs have an incorrect appearance in...

Aditya Keerthi noreply at github.com
Tue Nov 7 15:31:50 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1ce2532648afb8177d3f669049c097cbbdd557e1
      https://github.com/WebKit/WebKit/commit/1ce2532648afb8177d3f669049c097cbbdd557e1
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2023-11-07 (Tue, 07 Nov 2023)

  Changed paths:
    A LayoutTests/fast/forms/ios/range-vertical-rl-dir-ltr-expected-mismatch.html
    A LayoutTests/fast/forms/ios/range-vertical-rl-dir-ltr.html
    M Source/WebCore/rendering/RenderThemeIOS.mm

  Log Message:
  -----------
  [iOS] Range inputs have an incorrect appearance in vertical writing mode with a left-to-right-direction
https://bugs.webkit.org/show_bug.cgi?id=264352
rdar://118067444

Reviewed by Wenson Hsieh.

In the left-to-right direction, in vertical writing mode, the track should be
filled from top to bottom. Currently, it is filled from bottom to top, resulting
in the thumb being detached from the fill.

Fix by adjusting the clip used in this scenario.

* LayoutTests/fast/forms/ios/range-vertical-rl-dir-ltr-expected-mismatch.html: Added.
* LayoutTests/fast/forms/ios/range-vertical-rl-dir-ltr.html: Added.

Added a ref-mismatch test to verify that the track fills in different directions
based on the direction value. This is not a WPT, since it is not the case that
all platforms have a fill (example: macOS).

* Source/WebCore/rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::paintSliderTrackWithFormControlRefresh):

Canonical link: https://commits.webkit.org/270355@main




More information about the webkit-changes mailing list