[webkit-changes] [WebKit/WebKit] e2dca8: Make UnifiedPDFEnabled setting work on iOS

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e2dca80373448e8bc6604c065ebf86d6244ee563
      https://github.com/WebKit/WebKit/commit/e2dca80373448e8bc6604c065ebf86d6244ee563
  Author: Tim Horton <thorton at apple.com>
  Date:   2023-11-07 (Tue, 07 Nov 2023)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/plugins/PluginViewBase.h
    M Source/WebCore/rendering/RenderEmbeddedObject.cpp
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/RenderLayer.h
    M Source/WebCore/rendering/RenderLayerBacking.cpp
    M Source/WebCore/rendering/RenderLayerBacking.h
    M Source/WebCore/rendering/RenderLayerModelObject.cpp
    M Source/WebCore/rendering/RenderWidget.cpp
    M Source/WebKit/UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm

  Log Message:
  -----------
  Make UnifiedPDFEnabled setting work on iOS
https://bugs.webkit.org/show_bug.cgi?id=264341
rdar://118062175

Reviewed by Richard Robinson.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
Don't show the Unified PDF preference if the compile-time flag isn't enabled.

* Source/WebKit/UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:
(-[WKWebViewContentProviderRegistry initWithConfiguration:]):
Don't register WKPDFView as a custom content provider when Unified PDF is enabled.

* Source/WebCore/rendering/RenderLayerBacking.h:
* Source/WebCore/plugins/PluginViewBase.h:
(WebCore::PluginViewBase::willProvidePluginLayer const): Deleted.
(WebCore::PluginViewBase::attachPluginLayer): Deleted.
(WebCore::PluginViewBase::detachPluginLayer): Deleted.
* Source/WebCore/rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::requiresAcceleratedCompositing const):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::layerWillBeDestroyed): Deleted.
* Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):
(PluginWidgetIOS::PluginWidgetIOS): Deleted.
(PluginWidgetIOS::platformLayer const): Deleted.
(PluginWidgetIOS::willProvidePluginLayer const): Deleted.
(PluginWidgetIOS::attachPluginLayer): Deleted.
(PluginWidgetIOS::detachPluginLayer): Deleted.
Remove WebKitLegacy-specific plugin compositing code, which is both unused
and conflicting with our desire to use the Unified PDF plugin in modern WebKit
on iOS. Removing this will make iOS WebKit respect layerHostingStrategy(), which
the Unified PDF plugin depends on.

Canonical link: https://commits.webkit.org/270339@main