[webkit-changes] [WebKit/WebKit] c1ff31: Remove diagnostic logging from CachedResourceLoader

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c1ff3177cf14b7662ac2ec9ec59930604ac5c075
      https://github.com/WebKit/WebKit/commit/c1ff3177cf14b7662ac2ec9ec59930604ac5c075
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-11-07 (Tue, 07 Nov 2023)

  Changed paths:
    M Source/WebCore/loader/cache/CachedResourceLoader.cpp
    M Source/WebCore/page/DiagnosticLoggingKeys.cpp
    M Source/WebCore/page/DiagnosticLoggingKeys.h

  Log Message:
  -----------
  Remove diagnostic logging from CachedResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=264340
rdar://118061900

Reviewed by Chris Dumez.

These loggings are no longer used. And it turned out that they are very
costly when we are just hitting memory-cached resource path. We are sampling
with 5%, which means we hit this every 20 image elements for example.
This patch drops it from CachedResourceLoader. We should consider removing
the other loggings too in the subsequent patch.

* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy const):
(WebCore::logMemoryCacheResourceRequest): Deleted.
(WebCore::logRevalidation): Deleted.
(WebCore::logResourceRevalidationDecision): Deleted.
* Source/WebCore/page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::noCacheKey): Deleted.
(WebCore::DiagnosticLoggingKeys::noStoreKey): Deleted.
(WebCore::DiagnosticLoggingKeys::notInMemoryCacheKey): Deleted.
(WebCore::DiagnosticLoggingKeys::isExpiredKey): Deleted.
(WebCore::DiagnosticLoggingKeys::inMemoryCacheKey): Deleted.
(WebCore::DiagnosticLoggingKeys::reloadKey): Deleted.
(WebCore::DiagnosticLoggingKeys::revalidatingKey): Deleted.
(WebCore::DiagnosticLoggingKeys::unusedReasonCredentialSettingsKey): Deleted.
(WebCore::DiagnosticLoggingKeys::unusedReasonErrorKey): Deleted.
(WebCore::DiagnosticLoggingKeys::unusedReasonMustRevalidateNoValidatorKey): Deleted.
(WebCore::DiagnosticLoggingKeys::unusedReasonNoStoreKey): Deleted.
(WebCore::DiagnosticLoggingKeys::unusedReasonRedirectChainKey): Deleted.
(WebCore::DiagnosticLoggingKeys::unusedReasonReloadKey): Deleted.
(WebCore::DiagnosticLoggingKeys::unusedReasonTypeMismatchKey): Deleted.
* Source/WebCore/page/DiagnosticLoggingKeys.h:

Canonical link: https://commits.webkit.org/270338@main