[webkit-changes] [WebKit/WebKit] f93d71: [CSS] visited color should not be computed only fo...
Matthieu Dubet
noreply at github.com
Mon Nov 6 08:19:11 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f93d71021b6613c26c7db8da6be03f88169d32c5
https://github.com/WebKit/WebKit/commit/f93d71021b6613c26c7db8da6be03f88169d32c5
Author: Matthieu Dubet <m_dubet at apple.com>
Date: 2023-11-06 (Mon, 06 Nov 2023)
Changed paths:
A LayoutTests/imported/w3c/web-platform-tests/css/css-color/currentcolor-visited-fallback-expected.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-color/currentcolor-visited-fallback-ref.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-color/currentcolor-visited-fallback.html
A LayoutTests/imported/w3c/web-platform-tests/svg/color-inherit-link-visited-expected.html
A LayoutTests/imported/w3c/web-platform-tests/svg/color-inherit-link-visited-ref.html
A LayoutTests/imported/w3c/web-platform-tests/svg/color-inherit-link-visited.html
M LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/animate-elem-41-t-manual-expected.txt
M LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/animate-elem-78-t-manual-expected.txt
M LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/import/animate-elem-41-t-manual-expected.txt
M LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/import/animate-elem-78-t-manual-expected.txt
M LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/animate-elem-41-t-manual-expected.txt
M LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/animate-elem-78-t-manual-expected.txt
M Source/WebCore/style/StyleBuilder.cpp
M Source/WebCore/style/StyleBuilderState.h
Log Message:
-----------
[CSS] visited color should not be computed only for links
https://bugs.webkit.org/show_bug.cgi?id=264109
rdar://115289075
Reviewed by Antti Koivisto and Tim Nguyen.
Before this patch, we are computing the visited link color only
when inside a link which creates a bug when we should inherit a computed color from another kind of element.
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/currentcolor-visited-fallback-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/currentcolor-visited-fallback-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-color/currentcolor-visited-fallback.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/svg/color-inherit-link-visited-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/svg/color-inherit-link-visited-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/svg/color-inherit-link-visited.html: Added.
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/animate-elem-41-t-manual-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/animate-elem-78-t-manual-expected.txt:
* LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/import/animate-elem-41-t-manual-expected.txt:
* LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/import/animate-elem-78-t-manual-expected.txt:
* LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/animate-elem-41-t-manual-expected.txt:
* LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/animate-elem-78-t-manual-expected.txt:
* Source/WebCore/style/StyleBuilder.cpp:
(WebCore::Style::Builder::applyProperty):
* Source/WebCore/style/StyleBuilderState.h:
(WebCore::Style::BuilderState::applyPropertyToVisitedLinkStyle const):
Canonical link: https://commits.webkit.org/270270@main
More information about the webkit-changes
mailing list