[webkit-changes] [WebKit/WebKit] 30f6d5: Deprecate _WKFrameHandle.frameID

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 30f6d58c1ad8d7059ff4536c00081fb7520f3f1d
      https://github.com/WebKit/WebKit/commit/30f6d58c1ad8d7059ff4536c00081fb7520f3f1d
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-11-06 (Mon, 06 Nov 2023)

  Changed paths:
    M Source/WebKit/Shared/API/Cocoa/_WKFrameHandle.h
    M Source/WebKit/Shared/API/Cocoa/_WKFrameHandle.mm
    M Source/WebKit/Shared/Extensions/WebExtensionFrameIdentifier.h
    M Source/WebKit/UIProcess/API/C/WKFrameHandleRef.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Tools/WebKitTestRunner/TestController.cpp

  Log Message:
  -----------
  Deprecate _WKFrameHandle.frameID
https://bugs.webkit.org/show_bug.cgi?id=264199
rdar://117936267

Reviewed by Timothy Hatcher.

With site isolation, different processes can generate the number that is returned by this SPI,
which means it is no longer guaranteed to be unique within a page.  Deprecate it to discourage
future adoption and to allow me to catalog the work it will take to migrate.  I filed rdar://117936088
and rdar://117932176 to track that work.

* Source/WebKit/Shared/API/Cocoa/_WKFrameHandle.h:
* Source/WebKit/Shared/API/Cocoa/_WKFrameHandle.mm:
(-[_WKFrameHandle encodeWithCoder:]):
* Source/WebKit/Shared/Extensions/WebExtensionFrameIdentifier.h:
(WebKit::toWebExtensionFrameIdentifier):
* Source/WebKit/UIProcess/API/C/WKFrameHandleRef.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _evaluateJavaScript:asAsyncFunction:withSourceURL:withArguments:forceUserGesture:inFrame:inWorld:completionHandler:]):
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::saltForOrigin):

Canonical link: https://commits.webkit.org/270269@main