[webkit-changes] [WebKit/WebKit] bb55be: Expose <summary> element role as AXDisclosureTrian...

Joshua Hoffman noreply at github.com
Sat Nov 4 10:13:55 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bb55be859f7793e25dc9bcc330b0ca32de28bfbe
      https://github.com/WebKit/WebKit/commit/bb55be859f7793e25dc9bcc330b0ca32de28bfbe
  Author: Joshua Hoffman <jhoffman23 at apple.com>
  Date:   2023-11-04 (Sat, 04 Nov 2023)

  Changed paths:
    M LayoutTests/accessibility/display-contents/element-roles-expected.txt
    M LayoutTests/accessibility/mac/details-summary-expected.txt
    M LayoutTests/accessibility/mac/details-summary-role-description-expected.txt
    M LayoutTests/accessibility/mac/details-summary-role-description.html
    M LayoutTests/accessibility/mac/details-summary.html
    M LayoutTests/accessibility/mac/search-predicate-summary-expected.txt
    M LayoutTests/platform/mac-wk1/accessibility/aria-visible-element-roles-expected.txt
    M LayoutTests/platform/mac-wk2/accessibility/aria-visible-element-roles-expected.txt
    M Source/WebCore/accessibility/AXCoreObject.cpp
    M Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm

  Log Message:
  -----------
  Expose <summary> element role as AXDisclosureTriangle to match AX API
https://bugs.webkit.org/show_bug.cgi?id=108979
rdar://13661104

Reviewed by Chris Fleizach.

We had been exposing <summary> with an AXButton role in the past, but it should have an
AXDisclosureTriangle role to be aligned with the Accessibility API Mappings:
https://www.w3.org/TR/html-aam-1.0/#el-summary

* LayoutTests/accessibility/display-contents/element-roles-expected.txt:
* LayoutTests/accessibility/mac/details-summary-expected.txt:
* LayoutTests/accessibility/mac/details-summary-role-description-expected.txt:
* LayoutTests/accessibility/mac/details-summary-role-description.html:
* LayoutTests/accessibility/mac/details-summary.html:
* LayoutTests/accessibility/mac/search-predicate-summary-expected.txt:
* LayoutTests/platform/mac-wk1/accessibility/aria-visible-element-roles-expected.txt:
* LayoutTests/platform/mac-wk2/accessibility/aria-visible-element-roles-expected.txt:
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::value):
* Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::Accessibility::createPlatformRoleMap):

Canonical link: https://commits.webkit.org/270231@main




More information about the webkit-changes mailing list