[webkit-changes] [WebKit/WebKit] 67e35f: WebXRSession should not hold a unique ptr to WebXR...
Ada Chan
noreply at github.com
Sat Nov 4 09:56:05 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 67e35fd334d59ec2e9d3294b843884dcecdca493
https://github.com/WebKit/WebKit/commit/67e35fd334d59ec2e9d3294b843884dcecdca493
Author: Ada Chan <adachan at apple.com>
Date: 2023-11-04 (Sat, 04 Nov 2023)
Changed paths:
M Source/WebCore/Modules/webxr/WebXRSession.cpp
M Source/WebCore/Modules/webxr/WebXRSession.h
M Source/WebCore/Modules/webxr/WebXRSpace.h
Log Message:
-----------
WebXRSession should not hold a unique ptr to WebXRViewerSpace which is ref counted
https://bugs.webkit.org/show_bug.cgi?id=264200
rdar://115180471
Reviewed by Chris Dumez.
WebXRViewerSpace subclasses EventTarget and therefore should be ref-counted.
* Source/WebCore/Modules/webxr/WebXRSession.cpp:
(WebCore::WebXRSession::WebXRSession):
* Source/WebCore/Modules/webxr/WebXRSession.h:
* Source/WebCore/Modules/webxr/WebXRSpace.h:
(WebCore::WebXRViewerSpace::create):
Canonical link: https://commits.webkit.org/270230@main
More information about the webkit-changes
mailing list