[webkit-changes] [WebKit/WebKit] 4f1f74: AX: Add functionality to request AX clients to ann...

AndresGonzalezApple noreply at github.com
Thu Nov 2 13:28:43 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4f1f74a1f3c8f0a205331b1e19d7d7c989f8bfc0
      https://github.com/WebKit/WebKit/commit/4f1f74a1f3c8f0a205331b1e19d7d7c989f8bfc0
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2023-11-02 (Thu, 02 Nov 2023)

  Changed paths:
    A LayoutTests/accessibility/announcement-notification-expected.txt
    A LayoutTests/accessibility/announcement-notification.html
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WebCore/accessibility/AXLogger.cpp
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h
    M Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm
    M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h
    M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
    M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
    M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
    M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.h
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl

  Log Message:
  -----------
  AX: Add functionality to request AX clients to announce a given message to the user.
https://bugs.webkit.org/show_bug.cgi?id=263736
<rdar://problem/117544889>

Reviewed by Chris Fleizach.

This may be thought of as an analogous to an alert or banner but rendered by the AX client to the user in whatever modality it deems appropriate. E.G., a screen reader client may speak or braille the message. It is intended for short, non-content messages such as transient status or to indicate progress. This patch adds AXObjectCache::announce for this purpose, paralleling the existing postNotification methods also intended to notify AX clients of relevant changes.

* LayoutTests/accessibility/announcement-notification-expected.txt: Added.
* LayoutTests/accessibility/announcement-notification.html: Added.
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
Source/WebCore/accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::announce):
(WebCore::AXObjectCache::postPlatformAnnouncementNotification):
(WebCore::AXObjectCache::postPlatformNotification): Deleted.
* Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::notificationPlatformName):
(WebCore::AXObjectCache::postPlatformAnnouncementNotification):
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h:
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityOverrideProcessNotification:notificationData:]):
* Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformAnnouncementNotification):
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKAccessibilityAnnounce):
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
(WTR::AccessibilityController::announce):
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.h:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:

Canonical link: https://commits.webkit.org/270135@main




More information about the webkit-changes mailing list