[webkit-changes] [WebKit/WebKit] 3e8a39: AX: Fix thread safety issue in AXIsolatedTree::set...

Joshua Hoffman noreply at github.com
Thu Nov 2 13:01:41 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3e8a39cebd79433c45e1c4878fd017cd39545479
      https://github.com/WebKit/WebKit/commit/3e8a39cebd79433c45e1c4878fd017cd39545479
  Author: Joshua Hoffman <jhoffman23 at apple.com>
  Date:   2023-11-02 (Thu, 02 Nov 2023)

  Changed paths:
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h

  Log Message:
  -----------
  AX: Fix thread safety issue in AXIsolatedTree::setSelectedTextMarkerRange
https://bugs.webkit.org/show_bug.cgi?id=264045
rdar://117803232

Reviewed by Andres Gonzalez.

We need to hold a lock when modifying m_selectedTextMarkerRange since it is accessed on both
the main and AX thread.

* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::selectedTextMarkerRange):
(WebCore::AXIsolatedTree::setSelectedTextMarkerRange):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
(WebCore::AXIsolatedTree::selectedTextMarkerRange): Deleted.
(WebCore::AXIsolatedTree::setSelectedTextMarkerRange): Deleted.

Canonical link: https://commits.webkit.org/270134@main




More information about the webkit-changes mailing list