[webkit-changes] [WebKit/WebKit] 813aa2: Add empty stub for browser.notifications for Web E...

Timothy Hatcher noreply at github.com
Thu Nov 2 12:45:06 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 813aa2842251bc0f5b48f1a8bb817de1e6277c34
      https://github.com/WebKit/WebKit/commit/813aa2842251bc0f5b48f1a8bb817de1e6277c34
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2023-11-02 (Thu, 02 Nov 2023)

  Changed paths:
    M Source/WebKit/DerivedSources-input.xcfilelist
    M Source/WebKit/DerivedSources-output.xcfilelist
    M Source/WebKit/DerivedSources.make
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINamespaceCocoa.mm
    A Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINotificationsCocoa.mm
    M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPINamespace.h
    A Source/WebKit/WebProcess/Extensions/API/WebExtensionAPINotifications.h
    M Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPINamespace.idl
    A Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPINotifications.idl
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPINamespace.mm

  Log Message:
  -----------
  Add empty stub for browser.notifications for Web Extensions behind test mode.
https://webkit.org/b/264098
rdar://problem/117860475

Reviewed by Brian Weinstein.

We don't support this API, but it is useful to have a stub for testing extensions that
assume it is always present.

* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources-output.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj: Added new files. Xcode removed some duplicate
entries for ExtensionKitSPI.h, it is still present in one place.
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINamespaceCocoa.mm:
(WebKit::WebExtensionAPINamespace::isPropertyAllowed): Custom availability based on test mode
and permissions.
(WebKit::WebExtensionAPINamespace::notifications): Added.
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINotificationsCocoa.mm: Added.
(WebKit::WebExtensionAPINotifications::onClicked):
(WebKit::WebExtensionAPINotifications::onButtonClicked):
* Source/WebKit/WebProcess/Extensions/API/WebExtensionAPINamespace.h:
* Source/WebKit/WebProcess/Extensions/API/WebExtensionAPINotifications.h: Added.
* Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPINamespace.idl:
* Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPINotifications.idl: Added.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPINamespace.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/270132@main




More information about the webkit-changes mailing list