[webkit-changes] [WebKit/WebKit] 413e47: Refactor RevealItem to replace RVItem for IPC mess...

Brady Eidson noreply at github.com
Thu Nov 2 12:34:14 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 413e473787ebd7cd36840613a9a3d6216ab18c6b
      https://github.com/WebKit/WebKit/commit/413e473787ebd7cd36840613a9a3d6216ab18c6b
  Author: Brady Eidson <beidson at apple.com>
  Date:   2023-11-02 (Thu, 02 Nov 2023)

  Changed paths:
    M Source/WebCore/editing/cocoa/DictionaryLookup.mm
    M Source/WebKit/Shared/Cocoa/RevealItem.h
    M Source/WebKit/Shared/Cocoa/RevealItem.mm
    M Source/WebKit/Shared/Cocoa/RevealItem.serialization.in
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

  Log Message:
  -----------
  Refactor RevealItem to replace RVItem for IPC messaging
https://bugs.webkit.org/show_bug.cgi?id=264065
rdar://117822336

Reviewed by Megan Gardner.

The only RVItems that RevealItem every serialized for IPC were created internally with text and a range.
This patch changes serializing the RVItem to simply serializing the text and range.

* Source/WebCore/editing/cocoa/DictionaryLookup.mm:
* Source/WebKit/Shared/Cocoa/RevealItem.h:
(WebKit::RevealItemRange::RevealItemRange):
(WebKit::RevealItem::text const):
(WebKit::RevealItem::selectedRange const):
(WebKit::RevealItem::item const): Deleted.
* Source/WebKit/Shared/Cocoa/RevealItem.mm:
(WebKit::RevealItemRange::RevealItemRange):
(WebKit::RevealItem::RevealItem):
(WebKit::RevealItem::highlightRange const):
(WebKit::RevealItem::item const):
* Source/WebKit/Shared/Cocoa/RevealItem.serialization.in:
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::revealItemForCurrentSelection):

Canonical link: https://commits.webkit.org/270131@main




More information about the webkit-changes mailing list