[webkit-changes] [WebKit/WebKit] 40fd93: [Xcode] Dependencies in preprocessed sandbox profi...
Elliott Williams
noreply at github.com
Fri May 26 17:07:45 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 40fd93b1f2eff242effa1c79d30571d1547c9a74
https://github.com/WebKit/WebKit/commit/40fd93b1f2eff242effa1c79d30571d1547c9a74
Author: Elliott Williams <emw at apple.com>
Date: 2023-05-26 (Fri, 26 May 2023)
Changed paths:
M Source/WebKit/Configurations/SandboxProfiles.xcconfig
M Source/WebKit/Configurations/WebKit.xcconfig
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources-output.xcfilelist
M Source/WebKit/DerivedSources.make
A Source/WebKit/Scripts/preprocess-sandbox-profile-rule.sh
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
Log Message:
-----------
[Xcode] Dependencies in preprocessed sandbox profiles not tracked
https://bugs.webkit.org/show_bug.cgi?id=257276
rdar://problem/109790387
Reviewed by Brent Fulgham and Alexey Proskuryakov.
Reimplement the *.sb.in preprocessing task as a build rule, and have
clang emit a discovered dependency file. This means that the sandbox
profiles can be regenerated without effectively invalidating the entire
WebKit build, and that changes to common.sb and other included files
will cause profiles to regenerate.
Replicate this change in the iOS production-only "Sandbox Profiles"
target: First, change the target into a native static library so that
build rules are available, then add the *.sb.in profiles as resources.
(It doesn't have any sources, so it does not try to compile a static
library.)
* Source/WebKit/Configurations/WebKit.xcconfig: The project now tracks
*.sb.in files as inputs, so update the exclude rule here.
* Source/WebKit/DerivedSources-input.xcfilelist: Remove *.sb.in entries.
* Source/WebKit/DerivedSources-output.xcfilelist: Remove *.sb entries.
* Source/WebKit/DerivedSources.make: Delete sandbox generator rule.
* Source/WebKit/Scripts/preprocess-sandbox-profile-rule.sh: Added.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj: Add build rules,
target membership for *.sb.in files, and aforementioned Sandbox
Profiles refactoring.
Canonical link: https://commits.webkit.org/264612@main
More information about the webkit-changes
mailing list