[webkit-changes] [WebKit/WebKit] 6406ad: getDisplayMedia capture should mute other tabs whe...

youennf noreply at github.com
Fri May 26 17:02:00 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6406adae9bf283cb56cd4ec6c11ad2ce542f2aa1
      https://github.com/WebKit/WebKit/commit/6406adae9bf283cb56cd4ec6c11ad2ce542f2aa1
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-05-26 (Fri, 26 May 2023)

  Changed paths:
    M Source/WebKit/UIProcess/UserMediaProcessManager.cpp
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm

  Log Message:
  -----------
  getDisplayMedia capture should mute other tabs when starting
https://bugs.webkit.org/show_bug.cgi?id=257386
rdar://problem/109896538

Reviewed by Eric Carlson.

We were muting other tabs within UserMediaProcessManager::willCreateMediaStream but only for microphone and camera
as the screen/window code path was exiting early.
Move the call to mute other tabs in WebPageProxy::willStartCapture so that it covers all code paths.

Covered by API test.

* Source/WebKit/UIProcess/UserMediaProcessManager.cpp:
(WebKit::UserMediaProcessManager::willCreateMediaStream):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::willStartCapture):
* Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/264611@main




More information about the webkit-changes mailing list