[webkit-changes] [WebKit/WebKit] 7e2da0: ASSERTION FAILED: rootRenderer.isDocumentElementRe...

Thu May 25 13:05:25 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7e2da0a4cfeb0a3c3f6177876527381941fe62b0
      https://github.com/WebKit/WebKit/commit/7e2da0a4cfeb0a3c3f6177876527381941fe62b0
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-05-25 (Thu, 25 May 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderElement.cpp

  Log Message:
  -----------
  ASSERTION FAILED: rootRenderer.isDocumentElementRenderer() for fast/body-propagation/background-image/007-xhtml.xhtml
https://bugs.webkit.org/show_bug.cgi?id=257279

Reviewed by Simon Fraser.

Starting from r179145, we incorrectly assume that <body>'s parent is always <html>.
This patch changes "backgroundIsPaintedByRoot" logic to match what we do in RenderElement::styleWillChange.

* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::isVisibleInDocumentRect const):

Canonical link: https://commits.webkit.org/264535@main