[webkit-changes] [WebKit/WebKit] 8ac402: REGRESSION(252324 at main): crash in WebCore::Style::...

Antti Koivisto noreply at github.com
Thu May 25 13:02:07 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8ac402bd38f42315fb8865d301c7afafdf5b5efc
      https://github.com/WebKit/WebKit/commit/8ac402bd38f42315fb8865d301c7afafdf5b5efc
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-05-25 (Thu, 25 May 2023)

  Changed paths:
    A LayoutTests/fast/frames/stylesheet-mutation-focus-crash-expected.txt
    A LayoutTests/fast/frames/stylesheet-mutation-focus-crash.html
    M Source/WebCore/css/StyleRule.h
    M Source/WebCore/editing/FrameSelection.cpp

  Log Message:
  -----------
  REGRESSION(252324 at main): crash in WebCore::Style::ElementRuleCollector::ruleMatches
https://bugs.webkit.org/show_bug.cgi?id=252814
rdar://105545642

Reviewed by Ryosuke Niwa and Geoffrey Garen.

* LayoutTests/fast/frames/stylesheet-mutation-focus-crash-expected.txt: Added.
* LayoutTests/fast/frames/stylesheet-mutation-focus-crash.html: Added.
* Source/WebCore/css/StyleRule.h:
(WebCore::StyleRule::compiledSelectorForListIndex const):

Add some asserts.

* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::FrameSelection::pageActivationChanged):
(WebCore::FrameSelection::setFocused):

Scope style invalidation over the state change only. Previously it was scoped over event sending too.

Originally-landed-as: 259548.274 at safari-7615-branch (b25aa011e7aa). rdar://105545642
Canonical link: https://commits.webkit.org/264534@main




More information about the webkit-changes mailing list