[webkit-changes] [WebKit/WebKit] 52e6f0: [WebAuthn] Clean up observers in CcidService

Pascoe noreply at github.com
Wed May 24 14:33:47 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 52e6f05d3e91cf65392e590172ecd444c3fe9eda
      https://github.com/WebKit/WebKit/commit/52e6f05d3e91cf65392e590172ecd444c3fe9eda
  Author: J Pascoe <j_pascoe at apple.com>
  Date:   2023-05-24 (Wed, 24 May 2023)

  Changed paths:
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/CcidService.h
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/CcidService.mm

  Log Message:
  -----------
  [WebAuthn] Clean up observers in CcidService
https://bugs.webkit.org/show_bug.cgi?id=257240
rdar://109060751

Reviewed by Brent Fulgham.

This change ensures removeObserver:forKeyPath: is called for each observer we
add via addObserver in CcidService.

* Source/WebKit/UIProcess/WebAuthentication/Cocoa/CcidService.h:
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/CcidService.mm:
(WebKit::CcidService::~CcidService):
(WebKit::CcidService::removeObservers):
(WebKit::CcidService::platformStartDiscovery):
(WebKit::CcidService::updateSlots):
(-[_WKSmartCardSlotStateObserver observeValueForKeyPath:ofObject:change:context:]):
(-[_WKSmartCardSlotStateObserver removeObserver]):

Canonical link: https://commits.webkit.org/264485@main




More information about the webkit-changes mailing list