[webkit-changes] [WebKit/WebKit] 48c6a9: [baseline-alignment]Rename BaselineContext to Base...

Sammy Gill noreply at github.com
Wed May 24 14:23:12 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 48c6a9eda4fdc93834a69222bd4db466c7b94e52
      https://github.com/WebKit/WebKit/commit/48c6a9eda4fdc93834a69222bd4db466c7b94e52
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2023-05-24 (Wed, 24 May 2023)

  Changed paths:
    M Source/WebCore/rendering/BaselineAlignment.cpp
    M Source/WebCore/rendering/BaselineAlignment.h
    M Source/WebCore/rendering/GridBaselineAlignment.cpp
    M Source/WebCore/rendering/GridBaselineAlignment.h

  Log Message:
  -----------
  [baseline-alignment]Rename BaselineContext to BaselineAlignmentState.
https://bugs.webkit.org/show_bug.cgi?id=257233
rdar://109742609

Reviewed by Alan Baradlay.

This class is used primarily to provide an API for a formatting context
to interact with baseline sharing groups for baseline alignment. Also, a
baseline alignment context refers to a particular aspect of a formatting
context upon which baseline alignment occurs, such as lines in flex
layout.

Instead we can refer to this as BaselineAlignmentState since this is
the type of information we are holding in it.

* Source/WebCore/rendering/BaselineAlignment.cpp:
(WebCore::BaselineAlignmentState::BaselineAlignmentState):
(WebCore::BaselineAlignmentState::sharedGroup const):
(WebCore::BaselineAlignmentState::updateSharedGroup):
(WebCore::BaselineAlignmentState::findCompatibleSharedGroup):
(WebCore::BaselineContext::BaselineContext): Deleted.
(WebCore::BaselineContext::sharedGroup const): Deleted.
(WebCore::BaselineContext::updateSharedGroup): Deleted.
(WebCore::BaselineContext::findCompatibleSharedGroup): Deleted.
* Source/WebCore/rendering/BaselineAlignment.h:
* Source/WebCore/rendering/GridBaselineAlignment.cpp:
(WebCore::GridBaselineAlignment::updateBaselineAlignmentContext):
* Source/WebCore/rendering/GridBaselineAlignment.h:

Canonical link: https://commits.webkit.org/264484@main




More information about the webkit-changes mailing list