[webkit-changes] [WebKit/WebKit] e4c271: Increase max scrollbar update passes

JC Alvarado noreply at github.com
Mon May 22 13:03:58 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e4c271f0d9f8b4f3b7ea38335366734a81433920
      https://github.com/WebKit/WebKit/commit/e4c271f0d9f8b4f3b7ea38335366734a81433920
  Author: JC Alvarado <joncarlo at apple.com>
  Date:   2023-05-22 (Mon, 22 May 2023)

  Changed paths:
    A LayoutTests/fast/editing/frame-selection-in-child-view-crash-expected.txt
    A LayoutTests/fast/editing/frame-selection-in-child-view-crash.html
    M Source/WebCore/platform/ScrollView.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm

  Log Message:
  -----------
  Increase max scrollbar update passes
rdar://104064235

Reviewed by Simon Fraser.

Scrollbars are not fully updated in a single layout which
can lead to an additional layout in the scriptDisallowedScope
in FrameView::scrollRectToVisibleInChildView.

* LayoutTests/fast/editing/frame-selection-in-child-view-crash-expected.txt: Added.
* LayoutTests/fast/editing/frame-selection-in-child-view-crash.html: Added.
* Source/WebCore/platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):

* Tools/TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm:
(TEST):
Add scrollbarSize to width in WritingMode tests because we should
expect vertical overflow in these cases. This test would pass prior
to this patch despite the displayed WebView having both a vertical
and horizontal scroll bar.

Originally-landed-as: 259548.465 at safari-7615-branch (cf0b3436ba58). rdar://104064235
Canonical link: https://commits.webkit.org/264353@main




More information about the webkit-changes mailing list