[webkit-changes] [WebKit/WebKit] 89b88f: Adapt OOF with specified height case in availableL...

Rob Buis noreply at github.com
Mon May 22 13:01:55 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 89b88fd5da18c2017a4261858c4750c6487c4926
      https://github.com/WebKit/WebKit/commit/89b88fd5da18c2017a4261858c4750c6487c4926
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2023-05-22 (Mon, 22 May 2023)

  Changed paths:
    A LayoutTests/fast/css-grid-layout/positioned-grid-with-large-inset-and-scrollbar-expected.txt
    A LayoutTests/fast/css-grid-layout/positioned-grid-with-large-inset-and-scrollbar.html
    M Source/WebCore/rendering/RenderBlock.cpp

  Log Message:
  -----------
  Adapt OOF with specified height case in availableLogicalHeightForPercentageComputation
https://bugs.webkit.org/show_bug.cgi?id=253037
rdar://105938634

Reviewed by Alan Baradlay.

The computed height for OOF can result in being zero for certain insets (but never negative).
In that case subtracting scrollbar sizes could result in negative values like in the test case, so
clamp to zero.

* LayoutTests/fast/css-grid-layout/positioned-grid-with-large-inset-and-scrollbar-expected.txt: Added.
* LayoutTests/fast/css-grid-layout/positioned-grid-with-large-inset-and-scrollbar.html: Added.
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::availableLogicalHeightForPercentageComputation const):

Originally-landed-as: 260286.13 at webkit-2023.2-embargoed (0a7c35b68439). https://bugs.webkit.org/show_bug.cgi?id=253037
Canonical link: https://commits.webkit.org/264352@main




More information about the webkit-changes mailing list