[webkit-changes] [WebKit/WebKit] 140a13: REGRESSION (262629 at main): [ wk2 ] webgl/webgl-meta...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 140a13b384e73ce2e33cde7cbf8a58076f11ab52
      https://github.com/WebKit/WebKit/commit/140a13b384e73ce2e33cde7cbf8a58076f11ab52
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-05-22 (Mon, 22 May 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/mac-bigsur/TestExpectations
    M LayoutTests/platform/wincairo/TestExpectations
    A LayoutTests/webgl/webgl-backend-type-expected.txt
    A LayoutTests/webgl/webgl-backend-type.html
    M LayoutTests/webgl/webgl-fail-remote-context-ipc-buffer-allocation-no-crash.html
    R LayoutTests/webgl/webgl-metal-disabled-expected.txt
    R LayoutTests/webgl/webgl-metal-disabled.html
    R LayoutTests/webgl/webgl-metal-enabled-expected.txt
    R LayoutTests/webgl/webgl-metal-enabled.html
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl
    M Source/WebCore/testing/Internals.mm

  Log Message:
  -----------
  REGRESSION (262629 at main): [ wk2 ] webgl/webgl-metal-enabled.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=256841
rdar://108629326

Reviewed by Dan Glastonbury.

Remove webgl-metal-disabled.html webgl-metal-enabled.html
It's overly verbose, needing quite low-level access in Internals.
Also the condition platformSupportsMetal() is not accurate anymore
and it cannot work, as the feature detection cannot be done in WP
with IOKit blocking.

This is already tested with webgl/webgl-via-metal-flag-{off,on}.html
These test uses translated shader source to detect "did it use Metal".
webgl/webgl-via-metal-flag-off.html should pass when platform supports
OpenGL.
webgl/webgl-via-metal-flag-on.html should pass when platform supports
Metal.

Add a new test:
webgl/webgl-backend-type.html

Outputs the default backend type. This can be used to ensure that the
default does not flip accidentally.

Removes Internals::hasLowAndHighPowerGPUs(), similarly current
implementation cannot work with IOKit blocking, and the function is not
used at all.

* LayoutTests/TestExpectations:
* LayoutTests/webgl/webgl-metal-disabled-expected.txt: Removed.
* LayoutTests/webgl/webgl-metal-disabled.html: Removed.
* LayoutTests/webgl/webgl-metal-enabled-expected.txt: Removed.
* LayoutTests/webgl/webgl-metal-enabled.html: Removed.
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::requestedMetal): Deleted.
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.mm:
(WebCore::Internals::platformSupportsMetal): Deleted.

Canonical link: https://commits.webkit.org/264312@main