[webkit-changes] [WebKit/WebKit] edc3fa: [GTK] gsk_gl_command_queue_create_render_target: a...

Carlos Garcia Campos noreply at github.com
Sun May 21 22:31:39 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: edc3fa95e5155cd31a53ef133d6018d052754c39
      https://github.com/WebKit/WebKit/commit/edc3fa95e5155cd31a53ef133d6018d052754c39
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2023-05-21 (Sun, 21 May 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/egl/GLContext.cpp
    M Source/WebCore/platform/graphics/egl/GLContext.h
    M Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp

  Log Message:
  -----------
  [GTK] gsk_gl_command_queue_create_render_target: assertion failed (glCheckFramebufferStatus (GL_FRAMEBUFFER) == GL_FRAMEBUFFER_COMPLETE) when opening webkit://gpu
https://bugs.webkit.org/show_bug.cgi?id=256873

Reviewed by Michael Catanzaro.

Add ScopedGLContext class to create a GLContext that is made current for
the current scope and restores the previous current context on destruction.
In case of GLX being used by the UI process, use a dedicated thread to
create the EGL context and fill the GPU information.

* Source/WebCore/platform/graphics/egl/GLContext.cpp:
(WebCore::GLContext::ScopedGLContext::ScopedGLContext):
(WebCore::GLContext::ScopedGLContext::~ScopedGLContext):
* Source/WebCore/platform/graphics/egl/GLContext.h:
* Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp:
(WebKit::WebKitProtocolHandler::handleGPU):

Canonical link: https://commits.webkit.org/264311@main




More information about the webkit-changes mailing list