[webkit-changes] [WebKit/WebKit] 0c7bb6: [iOS] Auto-PiP on Yahoo.com may display black feed

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0c7bb633923a8ec42905119aecda921a90e6c2ea
      https://github.com/WebKit/WebKit/commit/0c7bb633923a8ec42905119aecda921a90e6c2ea
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-05-21 (Sun, 21 May 2023)

  Changed paths:
    M Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm

  Log Message:
  -----------
  [iOS] Auto-PiP on Yahoo.com may display black feed
https://bugs.webkit.org/show_bug.cgi?id=257059
rdar://109528876

Reviewed by Eric Carlson.

Auto-PiP (as opposed to an explicit PiP operation) works by creating a empty WebAVPlayerLayerView,
and WebAVPlayerViewController, and returning YES from the
-playerViewControllerShouldStartPictureInPictureFromInlineWhenEnteringBackground: delegate. However,
auto-PiP will transfer the video view from the empty WebAVPlayerLayerView to the PiP window, and if
the empty view doesn't have a video view, the resulting PiP window will be empty.

* Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:
(VideoFullscreenInterfaceAVKit::doSetup):

Canonical link: https://commits.webkit.org/264307@main