[webkit-changes] [WebKit/WebKit] 213b31: [iOS] Entering PIP when watching trailer flashes s...

Jer Noble noreply at github.com
Sun May 21 17:39:33 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 213b31adaa58864c00dd8e68cd36418e19a7ecc7
      https://github.com/WebKit/WebKit/commit/213b31adaa58864c00dd8e68cd36418e19a7ecc7
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-05-21 (Sun, 21 May 2023)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm

  Log Message:
  -----------
  [iOS] Entering PIP when watching trailer flashes smaller sized image/frame for a brief second
https://bugs.webkit.org/show_bug.cgi?id=257058
rdar://109437836

Reviewed by Eric Carlson.

When entering PiP, createLayerHostViewWithId() will be called by the WebContent process, though
the layer already exists and is parented in the PiP window. Setting the existing video view's
frame will cause it to unintentionally and visibly resize briefly. Only set the video view's
initial size when it is first created.

* Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(WebKit::VideoFullscreenManagerProxy::createLayerHostViewWithID):

Canonical link: https://commits.webkit.org/264306@main




More information about the webkit-changes mailing list