[webkit-changes] [WebKit/WebKit] 1ef1b7: Bail out early if m_element is deleted
Chirag Shah
noreply at github.com
Fri May 19 10:34:47 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1ef1b775b5ae7b6ae0e2124fc5faa7ec0916401b
https://github.com/WebKit/WebKit/commit/1ef1b775b5ae7b6ae0e2124fc5faa7ec0916401b
Author: Chirag M Shah <chirag_m_shah at apple.com>
Date: 2023-05-19 (Fri, 19 May 2023)
Changed paths:
A LayoutTests/fullscreen/element-clear-during-fullscreen-crash-expected.txt
A LayoutTests/fullscreen/element-clear-during-fullscreen-crash.html
M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
Log Message:
-----------
Bail out early if m_element is deleted
https://bugs.webkit.org/show_bug.cgi?id=253129
rdar://104290899
Reviewed by Jer Noble.
A call to WebFullScreenManager::willEnterFullScreen() can end up calling
WebFullScreenManager::clearElement() which can happen when location.hash
is changed. This clears the m_element which is then later used in
willEnterFullScreen(). This change bails out early if this happens and
cleans up the state-machine.
* LayoutTests/fullscreen/element-clear-during-fullscreen-crash-expected.txt: Added.
* LayoutTests/fullscreen/element-clear-during-fullscreen-crash.html: Added.
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::willEnterFullScreen):
Originally-landed-as: 259548.352 at safari-7615-branch (9f301d9e042e). rdar://104290899
Canonical link: https://commits.webkit.org/264263@main
More information about the webkit-changes
mailing list