[webkit-changes] [WebKit/WebKit] 402ed6: Do not parse caption-side: left / right as valid CSS

Ahmad Saleem noreply at github.com
Fri May 19 09:50:54 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 402ed699af6cddc14e0c068446c8e803d3bc9f91
      https://github.com/WebKit/WebKit/commit/402ed699af6cddc14e0c068446c8e803d3bc9f91
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-05-19 (Fri, 19 May 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-tables/parsing/caption-side-invalid-expected.txt
    M Source/WebCore/css/CSSPrimitiveValueMappings.h
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/rendering/style/RenderStyleConstants.cpp
    M Source/WebCore/rendering/style/RenderStyleConstants.h

  Log Message:
  -----------
  Do not parse caption-side: left / right as valid CSS

https://bugs.webkit.org/show_bug.cgi?id=256040
rdar://problem/108892083

Reviewed by Antti Koivisto.

This patch aligns WebKit with Blink / Chromium, Gecko / Firefox and Web-Spec [1]
by removing 'left' and 'right' parsing support for 'caption-side'

[1] https://drafts.csswg.org/css-tables/#propdef-caption-side

* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSPrimitiveValueMappings.h: Remove 'left' and 'right' case
* Source/WebCore/rendering/style/RenderStyleConstants.cpp: Ditto from caption-side function
* Source/WebCore/rendering/style/RenderStyleConstants.h: Ditto from caption-side enum
* LayoutTests/imported/w3c/web-platform-tests/css/css-tables/parsing/caption-side-invalid-expected.txt: Rebaselined

Canonical link: https://commits.webkit.org/264262@main




More information about the webkit-changes mailing list