[webkit-changes] [WebKit/WebKit] dfe31a: [WGSL] Report the correct workgroup size in EntryP...
Tadeu Zagallo
noreply at github.com
Thu May 18 23:16:59 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dfe31a43c822ff776a5303f79119741966f815ff
https://github.com/WebKit/WebKit/commit/dfe31a43c822ff776a5303f79119741966f815ff
Author: Tadeu Zagallo <tzagallo at apple.com>
Date: 2023-05-18 (Thu, 18 May 2023)
Changed paths:
M Source/WebGPU/WGSL/AST/ASTVisitor.cpp
M Source/WebGPU/WGSL/AST/ASTVisitor.h
M Source/WebGPU/WGSL/AST/ASTWorkgroupSizeAttribute.h
M Source/WebGPU/WGSL/EntryPointRewriter.cpp
M Source/WebGPU/WGSL/TypeCheck.cpp
Log Message:
-----------
[WGSL] Report the correct workgroup size in EntryPointInformation
https://bugs.webkit.org/show_bug.cgi?id=256969
rdar://109516093
Reviewed by Mike Wyrzykowski.
Previously, we were always reporting the workgroup size to be `1, 1, 1` to
the API. Instead, extract and use actual values from the AST. This code still
doesn't handle constants, but that will be done later in a separate pass.
* Source/WebGPU/WGSL/AST/ASTVisitor.cpp:
(WGSL::AST::extractInteger):
* Source/WebGPU/WGSL/AST/ASTVisitor.h:
* Source/WebGPU/WGSL/AST/ASTWorkgroupSizeAttribute.h:
* Source/WebGPU/WGSL/EntryPointRewriter.cpp:
(WGSL::EntryPointRewriter::EntryPointRewriter):
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::extractInteger): Deleted.
Canonical link: https://commits.webkit.org/264234@main
More information about the webkit-changes
mailing list