[webkit-changes] [WebKit/WebKit] 61646f: [WebGPU] Pipelines should check if createFunction ...

Tadeu Zagallo noreply at github.com
Thu May 18 23:13:35 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 61646fa2b75cc97a71988d7fdad17f3f9109b146
      https://github.com/WebKit/WebKit/commit/61646fa2b75cc97a71988d7fdad17f3f9109b146
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-05-18 (Thu, 18 May 2023)

  Changed paths:
    M Source/WebGPU/WebGPU/ComputePipeline.mm
    M Source/WebGPU/WebGPU/RenderPipeline.mm

  Log Message:
  -----------
  [WebGPU] Pipelines should check if createFunction failed
https://bugs.webkit.org/show_bug.cgi?id=256964
rdar://109515339

Reviewed by Mike Wyrzykowski.

If `createFunction` returns nil, assiging it to the Metal pipeline descriptor will
result in a crash. Instead, we should return an invalid pipeline so we can report
an error instead of crashing.

* Source/WebGPU/WebGPU/ComputePipeline.mm:
(WebGPU::Device::createComputePipeline):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::createRenderPipeline):

Canonical link: https://commits.webkit.org/264233@main




More information about the webkit-changes mailing list