[webkit-changes] [WebKit/WebKit] 0fcccf: Reland 263531 at main without Speedometer regression

Tim Nguyen noreply at github.com
Thu May 18 16:00:40 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0fcccfdd39fb158061c2eb8eb6dc1d0c220f568d
      https://github.com/WebKit/WebKit/commit/0fcccfdd39fb158061c2eb8eb6dc1d0c220f568d
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-05-18 (Thu, 18 May 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/color-mix-currentcolor-background-repaint-expected.xht
    A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/color-mix-currentcolor-background-repaint-parent-expected.xht
    A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/color-mix-currentcolor-background-repaint-parent.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/color-mix-currentcolor-background-repaint.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/color-mix-currentcolor-outline-repaint-expected.xht
    A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/color-mix-currentcolor-outline-repaint-parent-expected.xht
    A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/color-mix-currentcolor-outline-repaint-parent.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/color-mix-currentcolor-outline-repaint.html
    M Source/WebCore/rendering/style/RenderStyle.cpp
    M Source/WebCore/rendering/style/StyleBackgroundData.cpp

  Log Message:
  -----------
  Reland 263531 at main without Speedometer regression
https://bugs.webkit.org/show_bug.cgi?id=256674
rdar://109234330

Reviewed by Simon Fraser.

The ElementRuleCollector.cpp change was causing the perf regression, reland without it for now, since it's not strictly necessary to fix the repaint issue.

Also fix similar repaint issues with background/outline which were not fixed by the original patch.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/color-mix-currentcolor-background-repaint-expected.xht: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/color-mix-currentcolor-background-repaint-parent-expected.xht: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/color-mix-currentcolor-background-repaint-parent.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/color-mix-currentcolor-background-repaint.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/color-mix-currentcolor-outline-repaint-expected.xht: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/color-mix-currentcolor-outline-repaint-parent-expected.xht: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/color-mix-currentcolor-outline-repaint-parent.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/color-mix-currentcolor-outline-repaint.html: Added.
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresRepaint const):
* Source/WebCore/rendering/style/StyleBackgroundData.cpp:
(WebCore::StyleBackgroundData::isEquivalentForPainting const):

Canonical link: https://commits.webkit.org/264218@main




More information about the webkit-changes mailing list