[webkit-changes] [WebKit/WebKit] c3366d: Web Inspector: Console: add an internal property f...

[Devin Rousso]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c3366d5b4fd8c4e40e4cded5ac621dca518d5813
      https://github.com/WebKit/WebKit/commit/c3366d5b4fd8c4e40e4cded5ac621dca518d5813
  Author: Devin Rousso <hi at devinrousso.com>
  Date:   2023-05-17 (Wed, 17 May 2023)

  Changed paths:
    A LayoutTests/inspector/model/remote-object/proxy-expected.txt
    A LayoutTests/inspector/model/remote-object/proxy.html
    A LayoutTests/inspector/model/remote-object/weakref-expected.txt
    A LayoutTests/inspector/model/remote-object/weakref.html
    M Source/JavaScriptCore/inspector/InjectedScriptSource.js
    M Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp
    M Source/JavaScriptCore/inspector/JSInjectedScriptHost.h
    M Source/JavaScriptCore/inspector/JSInjectedScriptHostPrototype.cpp
    M Source/JavaScriptCore/inspector/protocol/Runtime.json
    M Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js

  Log Message:
  -----------
  Web Inspector: Console: add an internal property for the `target` of a `WeakRef`
https://bugs.webkit.org/show_bug.cgi?id=256710

Reviewed by Patrick Angle.

Add special handling for `WeakRef` to make it easier for developers to at-a-glance know what the `WeakRef` is for (i.e. what's the `target`).

* Source/JavaScriptCore/inspector/InjectedScriptSource.js:
(InjectedScript.prototype._forEachPropertyDescriptor):
(RemoteObject):
(RemoteObject.describe):
* Source/JavaScriptCore/inspector/JSInjectedScriptHost.h:
* Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp:
(Inspector::JSInjectedScriptHost::subtype):
(Inspector::JSInjectedScriptHost::getInternalProperties):
(Inspector::JSInjectedScriptHost::weakRefTargetValue): Added.
* Source/JavaScriptCore/inspector/JSInjectedScriptHostPrototype.cpp:
(Inspector::JSInjectedScriptHostPrototype::finishCreation):
(Inspector::jsInjectedScriptHostPrototypeFunctionWeakRefTargetValue): Added.
* Source/JavaScriptCore/inspector/protocol/Runtime.json:
* Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:
(WI.ConsoleMessageView.prototype._formatParameter):

* LayoutTests/inspector/model/remote-object/weakref.html: Added.
* LayoutTests/inspector/model/remote-object/weakref-expected.txt: Added.

* LayoutTests/inspector/model/remote-object/proxy.html: Added.
* LayoutTests/inspector/model/remote-object/proxy-expected.txt: Added.

Drive-by: Add tests for `Proxy` accidentally removed in 217300 at main.
Canonical link: https://commits.webkit.org/264171@main