[webkit-changes] [WebKit/WebKit] f0bec4: Rename FrameLoaderClient to LocalFrameLoaderClient

Alex Christensen noreply at github.com
Wed May 17 12:58:51 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f0bec4455223795c12327877045aa001d48a6806
      https://github.com/WebKit/WebKit/commit/f0bec4455223795c12327877045aa001d48a6806
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-05-17 (Wed, 17 May 2023)

  Changed paths:
    M Source/WebCore/Headers.cmake
    M Source/WebCore/Modules/websockets/WebSocket.cpp
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/accessibility/AccessibilityObjectInterface.h
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
    M Source/WebCore/bindings/js/ScriptController.cpp
    M Source/WebCore/bindings/js/ScriptControllerMac.mm
    M Source/WebCore/contentextensions/ContentExtensionsBackend.cpp
    M Source/WebCore/dom/DOMImplementation.cpp
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/DocumentStorageAccess.cpp
    M Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm
    M Source/WebCore/history/BackForwardCache.cpp
    M Source/WebCore/history/CachedFrame.cpp
    M Source/WebCore/history/CachedPage.cpp
    M Source/WebCore/html/HTMLAnchorElement.cpp
    M Source/WebCore/html/HTMLCanvasElement.cpp
    M Source/WebCore/html/HTMLFormElement.cpp
    M Source/WebCore/html/HTMLFrameSetElement.cpp
    M Source/WebCore/html/HTMLLinkElement.cpp
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/html/HTMLPlugInImageElement.cpp
    M Source/WebCore/html/ImageDocument.cpp
    M Source/WebCore/html/MediaDocument.cpp
    M Source/WebCore/html/ModelDocument.cpp
    M Source/WebCore/html/PluginDocument.cpp
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
    M Source/WebCore/html/parser/HTMLConstructionSite.cpp
    M Source/WebCore/loader/ContentFilter.cpp
    M Source/WebCore/loader/DocumentLoader.cpp
    M Source/WebCore/loader/DocumentThreadableLoader.cpp
    M Source/WebCore/loader/DocumentWriter.cpp
    M Source/WebCore/loader/EmptyClients.cpp
    M Source/WebCore/loader/EmptyFrameLoaderClient.h
    M Source/WebCore/loader/FrameLoader.cpp
    M Source/WebCore/loader/FrameLoader.h
    R Source/WebCore/loader/FrameLoaderClient.h
    M Source/WebCore/loader/HistoryController.cpp
    M Source/WebCore/loader/LinkLoader.cpp
    A Source/WebCore/loader/LocalFrameLoaderClient.h
    M Source/WebCore/loader/MediaResourceLoader.cpp
    M Source/WebCore/loader/MixedContentChecker.cpp
    M Source/WebCore/loader/MixedContentChecker.h
    M Source/WebCore/loader/NetscapePlugInStreamLoader.cpp
    M Source/WebCore/loader/PingLoader.cpp
    M Source/WebCore/loader/PolicyChecker.cpp
    M Source/WebCore/loader/PolicyChecker.h
    M Source/WebCore/loader/ProgressTracker.cpp
    M Source/WebCore/loader/ResourceLoadNotifier.cpp
    M Source/WebCore/loader/ResourceLoader.cpp
    M Source/WebCore/loader/SubframeLoader.cpp
    M Source/WebCore/loader/SubframeLoader.h
    M Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp
    M Source/WebCore/loader/appcache/ApplicationCacheHost.cpp
    M Source/WebCore/loader/cache/CachedImage.cpp
    M Source/WebCore/loader/cache/CachedResource.cpp
    M Source/WebCore/loader/cache/CachedResourceLoader.cpp
    M Source/WebCore/loader/icon/IconLoader.cpp
    M Source/WebCore/loader/ios/LegacyPreviewLoader.mm
    M Source/WebCore/loader/mac/ResourceLoaderMac.mm
    M Source/WebCore/page/Chrome.cpp
    M Source/WebCore/page/ContextMenuController.cpp
    M Source/WebCore/page/DOMWindowExtension.cpp
    M Source/WebCore/page/History.cpp
    M Source/WebCore/page/LocalDOMWindow.cpp
    M Source/WebCore/page/LocalFrame.cpp
    M Source/WebCore/page/LocalFrame.h
    M Source/WebCore/page/LocalFrameView.cpp
    M Source/WebCore/page/Navigator.cpp
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/PageConfiguration.cpp
    M Source/WebCore/page/PageConfiguration.h
    M Source/WebCore/page/PerformanceLogging.cpp
    M Source/WebCore/page/WebKitNamespace.cpp
    M Source/WebCore/platform/network/SynchronousLoaderClient.cpp
    M Source/WebCore/rendering/RenderEmbeddedObject.cpp
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/style/StyleScopeRuleSets.cpp
    M Source/WebCore/workers/service/ServiceWorkerContainer.cpp
    M Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp
    M Source/WebCore/workers/service/ServiceWorkerProvider.cpp
    M Source/WebCore/workers/service/context/SWContextManager.cpp
    M Source/WebKit/Sources.txt
    M Source/WebKit/SourcesCocoa.txt
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp
    M Source/WebKit/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp
    M Source/WebKit/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp
    M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
    M Source/WebKit/WebProcess/Network/WebResourceLoader.cpp
    M Source/WebKit/WebProcess/Plugins/PluginView.cpp
    M Source/WebKit/WebProcess/Storage/RemoteWorkerFrameLoaderClient.h
    M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp
    M Source/WebKit/WebProcess/Storage/WebSharedWorkerContextManagerConnection.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
    R Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
    R Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h
    A Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp
    A Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h
    M Source/WebKit/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/curl/WebFrameNetworkingContext.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/curl/WebFrameNetworkingContext.h
    R Source/WebKit/WebProcess/WebCoreSupport/ios/WebFrameLoaderClientIOS.mm
    A Source/WebKit/WebProcess/WebCoreSupport/ios/WebLocalFrameLoaderClientIOS.mm
    M Source/WebKit/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h
    M Source/WebKit/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm
    M Source/WebKit/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h
    M Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp
    M Source/WebKit/WebProcess/WebPage/WebFrame.cpp
    M Source/WebKit/WebProcess/WebPage/WebFrame.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
    M Source/WebKitLegacy/ios/WebView/WebPDFViewIOS.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameNetworkingContext.mm
    M Source/WebKitLegacy/mac/WebView/WebFrame.mm
    M Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm
    M Source/WebKitLegacy/mac/WebView/WebView.mm

  Log Message:
  -----------
  Rename FrameLoaderClient to LocalFrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=256904

Reviewed by Chris Dumez.

This is preparation for sharing decidePolicyForNavigationAction between LocalFrame and RemoteFrame.

* Source/WebCore/Modules/websockets/WebSocket.cpp:
* Source/WebCore/accessibility/AccessibilityObjectInterface.h:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
* Source/WebCore/bindings/js/ScriptController.cpp:
* Source/WebCore/bindings/js/ScriptControllerMac.mm:
* Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:
* Source/WebCore/dom/DOMImplementation.cpp:
* Source/WebCore/dom/Document.cpp:
* Source/WebCore/dom/DocumentStorageAccess.cpp:
* Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:
* Source/WebCore/history/BackForwardCache.cpp:
* Source/WebCore/history/CachedFrame.cpp:
* Source/WebCore/history/CachedPage.cpp:
* Source/WebCore/html/HTMLAnchorElement.cpp:
* Source/WebCore/html/HTMLCanvasElement.cpp:
* Source/WebCore/html/HTMLFormElement.cpp:
* Source/WebCore/html/HTMLFrameSetElement.cpp:
* Source/WebCore/html/HTMLLinkElement.cpp:
* Source/WebCore/html/HTMLMediaElement.cpp:
* Source/WebCore/html/HTMLPlugInImageElement.cpp:
* Source/WebCore/html/ImageDocument.cpp:
* Source/WebCore/html/MediaDocument.cpp:
* Source/WebCore/html/ModelDocument.cpp:
* Source/WebCore/html/PluginDocument.cpp:
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
* Source/WebCore/html/parser/HTMLConstructionSite.cpp:
* Source/WebCore/loader/ContentFilter.cpp:
* Source/WebCore/loader/DocumentLoader.cpp:
* Source/WebCore/loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::cancel):
* Source/WebCore/loader/DocumentWriter.cpp:
* Source/WebCore/loader/EmptyClients.cpp:
(WebCore::pageConfigurationWithEmptyClients):
* Source/WebCore/loader/EmptyFrameLoaderClient.h:
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::loadInSameDocument):
(WebCore::LocalFrameLoaderClient::hasHTMLView const):
(WebCore::FrameLoaderClient::hasHTMLView const): Deleted.
* Source/WebCore/loader/FrameLoader.h:
* Source/WebCore/loader/HistoryController.cpp:
(WebCore::FrameLoader::HistoryController::restoreScrollPositionAndViewState):
* Source/WebCore/loader/LinkLoader.cpp:
* Source/WebCore/loader/LocalFrameLoaderClient.h: Renamed from Source/WebCore/loader/FrameLoaderClient.h.
* Source/WebCore/loader/MediaResourceLoader.cpp:
* Source/WebCore/loader/MixedContentChecker.cpp:
* Source/WebCore/loader/MixedContentChecker.h:
* Source/WebCore/loader/NetscapePlugInStreamLoader.cpp:
* Source/WebCore/loader/PingLoader.cpp:
* Source/WebCore/loader/PolicyChecker.cpp:
* Source/WebCore/loader/PolicyChecker.h:
* Source/WebCore/loader/ProgressTracker.cpp:
* Source/WebCore/loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::didFailToLoad):
(WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
(WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
(WebCore::ResourceLoadNotifier::dispatchDidReceiveData):
(WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
(WebCore::ResourceLoadNotifier::dispatchDidFailLoading):
* Source/WebCore/loader/ResourceLoader.cpp:
* Source/WebCore/loader/SubframeLoader.cpp:
* Source/WebCore/loader/SubframeLoader.h:
* Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp:
* Source/WebCore/loader/appcache/ApplicationCacheHost.cpp:
* Source/WebCore/loader/cache/CachedImage.cpp:
* Source/WebCore/loader/cache/CachedResource.cpp:
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
* Source/WebCore/loader/icon/IconLoader.cpp:
* Source/WebCore/loader/ios/LegacyPreviewLoader.mm:
* Source/WebCore/loader/mac/ResourceLoaderMac.mm:
* Source/WebCore/page/Chrome.cpp:
* Source/WebCore/page/ContextMenuController.cpp:
* Source/WebCore/page/DOMWindowExtension.cpp:
* Source/WebCore/page/History.cpp:
* Source/WebCore/page/LocalDOMWindow.cpp:
* Source/WebCore/page/LocalFrame.cpp:
(WebCore::LocalFrame::LocalFrame):
(WebCore::LocalFrame::createMainFrame):
(WebCore::LocalFrame::createSubframe):
(WebCore::LocalFrame::createSubframeHostedInAnotherProcess):
* Source/WebCore/page/LocalFrame.h:
* Source/WebCore/page/LocalFrameView.cpp:
* Source/WebCore/page/Navigator.cpp:
* Source/WebCore/page/Page.cpp:
(WebCore::createMainFrame):
* Source/WebCore/page/PageConfiguration.cpp:
(WebCore::PageConfiguration::PageConfiguration):
* Source/WebCore/page/PageConfiguration.h:
* Source/WebCore/page/PerformanceLogging.cpp:
* Source/WebCore/page/WebKitNamespace.cpp:
* Source/WebCore/platform/network/SynchronousLoaderClient.cpp:
(WebCore::SynchronousLoaderClient::shouldUseCredentialStorage):
(WebCore::SynchronousLoaderClient::canAuthenticateAgainstProtectionSpaceAsync):
* Source/WebCore/rendering/RenderEmbeddedObject.cpp:
* Source/WebCore/rendering/RenderLayer.cpp:
* Source/WebCore/style/StyleScopeRuleSets.cpp:
* Source/WebCore/workers/service/ServiceWorkerContainer.cpp:
* Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp:
* Source/WebCore/workers/service/ServiceWorkerProvider.cpp:
* Source/WebCore/workers/service/context/SWContextManager.cpp:
* Source/WebKit/WebProcess/Network/WebResourceLoader.cpp:
* Source/WebKit/WebProcess/Plugins/PluginView.cpp:
* Source/WebKit/WebProcess/Storage/RemoteWorkerFrameLoaderClient.h:
(isType):
* Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::installServiceWorker):
* Source/WebKit/WebProcess/Storage/WebSharedWorkerContextManagerConnection.cpp:
(WebKit::WebSharedWorkerContextManagerConnection::launchSharedWorker):
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
(WebKit::toWebFrameLoaderClient):
* Source/WebKit/WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp:
* Source/WebKit/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
* Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp:
* Source/WebKit/WebProcess/WebPage/WebFrame.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::clientForMainFrame):
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
* Source/WebKitLegacy/ios/WebView/WebPDFViewIOS.mm:
* Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebFrameNetworkingContext.mm:
* Source/WebKitLegacy/mac/WebView/WebFrame.mm:
(kit):
* Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm:
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):

Canonical link: https://commits.webkit.org/264170@main




More information about the webkit-changes mailing list