[webkit-changes] [WebKit/WebKit] e3b4ab: [WGSL] Make expression nodes arena allocated

Tadeu Zagallo noreply at github.com
Wed May 10 01:48:44 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e3b4aba1b3abf42f1f959b26b3c52df95132cd2d
      https://github.com/WebKit/WebKit/commit/e3b4aba1b3abf42f1f959b26b3c52df95132cd2d
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-05-10 (Wed, 10 May 2023)

  Changed paths:
    M Source/WebGPU/WGSL/AST/ASTAbstractFloatLiteral.h
    M Source/WebGPU/WGSL/AST/ASTAbstractIntegerLiteral.h
    M Source/WebGPU/WGSL/AST/ASTBinaryExpression.h
    M Source/WebGPU/WGSL/AST/ASTBitcastExpression.h
    M Source/WebGPU/WGSL/AST/ASTBoolLiteral.h
    M Source/WebGPU/WGSL/AST/ASTBuilder.h
    M Source/WebGPU/WGSL/AST/ASTCallExpression.h
    M Source/WebGPU/WGSL/AST/ASTExpression.h
    M Source/WebGPU/WGSL/AST/ASTFieldAccessExpression.h
    M Source/WebGPU/WGSL/AST/ASTFloat32Literal.h
    M Source/WebGPU/WGSL/AST/ASTForStatement.h
    M Source/WebGPU/WGSL/AST/ASTIdentifierExpression.h
    M Source/WebGPU/WGSL/AST/ASTIdentityExpression.h
    M Source/WebGPU/WGSL/AST/ASTIndexAccessExpression.h
    M Source/WebGPU/WGSL/AST/ASTReturnStatement.h
    M Source/WebGPU/WGSL/AST/ASTSigned32Literal.h
    M Source/WebGPU/WGSL/AST/ASTTypeName.h
    M Source/WebGPU/WGSL/AST/ASTUnaryExpression.h
    M Source/WebGPU/WGSL/AST/ASTUnsigned32Literal.h
    M Source/WebGPU/WGSL/AST/ASTVariable.h
    M Source/WebGPU/WGSL/AST/ASTWorkgroupSizeAttribute.h
    M Source/WebGPU/WGSL/EntryPointRewriter.cpp
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
    M Source/WebGPU/WGSL/MangleNames.cpp
    M Source/WebGPU/WGSL/Parser.cpp
    M Source/WebGPU/WGSL/TypeCheck.cpp
    M Source/WebGPU/WGSL/WGSLShaderModule.h
    M Tools/TestWebKitAPI/Tests/WGSL/ConstLiteralTests.cpp
    M Tools/TestWebKitAPI/Tests/WGSL/ParserTests.cpp
    M Tools/TestWebKitAPI/Tests/WGSL/TestWGSLAPI.h

  Log Message:
  -----------
  [WGSL] Make expression nodes arena allocated
https://bugs.webkit.org/show_bug.cgi?id=256530
rdar://109104698

Reviewed by Dan Glastonbury.

Continue converting nodes to be arena allocated.

* Source/WebGPU/WGSL/AST/ASTAbstractFloatLiteral.h:
* Source/WebGPU/WGSL/AST/ASTAbstractIntegerLiteral.h:
* Source/WebGPU/WGSL/AST/ASTBinaryExpression.h:
(WGSL::AST::BinaryExpression::operation const):
(WGSL::AST::BinaryExpression::leftExpression):
(WGSL::AST::BinaryExpression::rightExpression):
* Source/WebGPU/WGSL/AST/ASTBitcastExpression.h:
* Source/WebGPU/WGSL/AST/ASTBoolLiteral.h:
* Source/WebGPU/WGSL/AST/ASTBuilder.h:
* Source/WebGPU/WGSL/AST/ASTCallExpression.h:
* Source/WebGPU/WGSL/AST/ASTExpression.h:
(WGSL::AST::Expression::Expression):
* Source/WebGPU/WGSL/AST/ASTFieldAccessExpression.h:
* Source/WebGPU/WGSL/AST/ASTFloat32Literal.h:
* Source/WebGPU/WGSL/AST/ASTForStatement.h:
* Source/WebGPU/WGSL/AST/ASTIdentifierExpression.h:
* Source/WebGPU/WGSL/AST/ASTIdentityExpression.h:
* Source/WebGPU/WGSL/AST/ASTIndexAccessExpression.h:
* Source/WebGPU/WGSL/AST/ASTReturnStatement.h:
* Source/WebGPU/WGSL/AST/ASTSigned32Literal.h:
* Source/WebGPU/WGSL/AST/ASTTypeName.h:
(WGSL::AST::ArrayTypeName::maybeElementCount const):
(WGSL::AST::ArrayTypeName::ArrayTypeName):
* Source/WebGPU/WGSL/AST/ASTUnaryExpression.h:
* Source/WebGPU/WGSL/AST/ASTUnsigned32Literal.h:
* Source/WebGPU/WGSL/AST/ASTVariable.h:
* Source/WebGPU/WGSL/AST/ASTWorkgroupSizeAttribute.h:
* Source/WebGPU/WGSL/EntryPointRewriter.cpp:
(WGSL::EntryPointRewriter::materialize):
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::visit):
* Source/WebGPU/WGSL/MangleNames.cpp:
(WGSL::NameManglerVisitor::visit):
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser<Lexer>::parseAttribute):
(WGSL::Parser<Lexer>::parseArrayType):
(WGSL::Parser<Lexer>::parseVariableWithAttributes):
(WGSL::Parser<Lexer>::parseForStatement):
(WGSL::Parser<Lexer>::parseReturnStatement):
(WGSL::Parser<Lexer>::parseShortCircuitExpression):
(WGSL::Parser<Lexer>::parseRelationalExpressionPostUnary):
(WGSL::Parser<Lexer>::parseShiftExpressionPostUnary):
(WGSL::Parser<Lexer>::parseAdditiveExpressionPostUnary):
(WGSL::Parser<Lexer>::parseBitwiseExpressionPostUnary):
(WGSL::Parser<Lexer>::parseMultiplicativeExpressionPostUnary):
(WGSL::Parser<Lexer>::parseUnaryExpression):
(WGSL::Parser<Lexer>::parsePostfixExpression):
(WGSL::Parser<Lexer>::parsePrimaryExpression):
(WGSL::Parser<Lexer>::parseCoreLHSExpression):
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
(WGSL::TypeChecker::chooseOverload):
* Source/WebGPU/WGSL/WGSLShaderModule.h:
(WGSL::ShaderModule::replace):

Canonical link: https://commits.webkit.org/263895@main




More information about the webkit-changes mailing list