[webkit-changes] [WebKit/WebKit] 8efe93: CollectionType should be an enum class

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8efe93387102c06cb10d329f5bf6d01abccdb5b0
      https://github.com/WebKit/WebKit/commit/8efe93387102c06cb10d329f5bf6d01abccdb5b0
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-05-10 (Wed, 10 May 2023)

  Changed paths:
    M Source/WebCore/bindings/js/JSHTMLCollectionCustom.cpp
    M Source/WebCore/dom/AllDescendantsCollection.h
    M Source/WebCore/dom/ClassCollection.cpp
    M Source/WebCore/dom/ClassCollection.h
    M Source/WebCore/dom/ContainerNode.cpp
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Document.h
    M Source/WebCore/dom/NodeRareData.h
    M Source/WebCore/dom/TagCollection.cpp
    M Source/WebCore/dom/TagCollection.h
    M Source/WebCore/html/CachedHTMLCollectionInlines.h
    M Source/WebCore/html/CollectionType.h
    M Source/WebCore/html/GenericCachedHTMLCollection.cpp
    M Source/WebCore/html/HTMLAllCollection.cpp
    M Source/WebCore/html/HTMLAllCollection.h
    M Source/WebCore/html/HTMLCollection.cpp
    M Source/WebCore/html/HTMLDataListElement.cpp
    M Source/WebCore/html/HTMLFieldSetElement.cpp
    M Source/WebCore/html/HTMLFormControlsCollection.cpp
    M Source/WebCore/html/HTMLFormControlsCollection.h
    M Source/WebCore/html/HTMLFormElement.cpp
    M Source/WebCore/html/HTMLMapElement.cpp
    M Source/WebCore/html/HTMLNameCollection.h
    M Source/WebCore/html/HTMLNameCollectionInlines.h
    M Source/WebCore/html/HTMLOptionsCollection.cpp
    M Source/WebCore/html/HTMLOptionsCollection.h
    M Source/WebCore/html/HTMLSelectElement.cpp
    M Source/WebCore/html/HTMLTableElement.cpp
    M Source/WebCore/html/HTMLTableRowElement.cpp
    M Source/WebCore/html/HTMLTableRowsCollection.cpp
    M Source/WebCore/html/HTMLTableRowsCollection.h
    M Source/WebCore/html/HTMLTableSectionElement.cpp
    M Source/WebKitLegacy/mac/DOM/DOMHTML.mm

  Log Message:
  -----------
  CollectionType should be an enum class
https://bugs.webkit.org/show_bug.cgi?id=256504

Reviewed by Chris Dumez.

* Source/WebCore/bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::toJSNewlyCreated):
* Source/WebCore/dom/AllDescendantsCollection.h:
(WebCore::AllDescendantsCollection::create):
* Source/WebCore/dom/ClassCollection.cpp:
(WebCore::ClassCollection::create):
* Source/WebCore/dom/ClassCollection.h:
* Source/WebCore/dom/ContainerNode.cpp:
(WebCore::ContainerNode::getElementsByTagName):
(WebCore::ContainerNode::getElementsByClassName):
(WebCore::ContainerNode::children):
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
(WebCore::Document::all):
(WebCore::Document::allFilteredByName):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/NodeRareData.h:
(WebCore::NodeListsNodeData::namedCollectionKey):
* Source/WebCore/dom/TagCollection.cpp:
(WebCore::TagCollectionNS::TagCollectionNS):
(WebCore::TagCollection::TagCollection):
(WebCore::HTMLTagCollection::HTMLTagCollection):
* Source/WebCore/dom/TagCollection.h:
* Source/WebCore/html/CachedHTMLCollectionInlines.h:
(WebCore::traversalType>::namedItem const):
* Source/WebCore/html/CollectionType.h:
(): Deleted.
* Source/WebCore/html/GenericCachedHTMLCollection.cpp:
(WebCore::GenericCachedHTMLCollection<traversalType>::elementMatches const):
* Source/WebCore/html/HTMLAllCollection.cpp:
(WebCore::HTMLAllNamedSubCollection::HTMLAllNamedSubCollection):
* Source/WebCore/html/HTMLAllCollection.h:
* Source/WebCore/html/HTMLCollection.cpp:
(WebCore::HTMLCollection::rootTypeFromCollectionType):
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::~HTMLCollection):
(WebCore::HTMLCollection::updateNamedElementCache const):
* Source/WebCore/html/HTMLDataListElement.cpp:
(WebCore::HTMLDataListElement::options):
* Source/WebCore/html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::elements):
* Source/WebCore/html/HTMLFormControlsCollection.cpp:
(WebCore::HTMLFormControlsCollection::HTMLFormControlsCollection):
* Source/WebCore/html/HTMLFormControlsCollection.h:
* Source/WebCore/html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::elements):
* Source/WebCore/html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::areas):
* Source/WebCore/html/HTMLNameCollection.h:
* Source/WebCore/html/HTMLNameCollectionInlines.h:
(WebCore::traversalType>::~HTMLNameCollection):
* Source/WebCore/html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::HTMLOptionsCollection):
* Source/WebCore/html/HTMLOptionsCollection.h:
* Source/WebCore/html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::selectedOptions):
(WebCore::HTMLSelectElement::options):
(WebCore::HTMLSelectElement::invalidateSelectedItems):
(WebCore::HTMLSelectElement::setRecalcListItems):
* Source/WebCore/html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::rows):
(WebCore::HTMLTableElement::tBodies):
* Source/WebCore/html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::cells):
* Source/WebCore/html/HTMLTableRowsCollection.cpp:
(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
(WebCore::HTMLTableRowsCollection::create):
* Source/WebCore/html/HTMLTableRowsCollection.h:
* Source/WebCore/html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::rows):
* Source/WebKitLegacy/mac/DOM/DOMHTML.mm:
(kitClass):

Canonical link: https://commits.webkit.org/263894@main