[webkit-changes] [WebKit/WebKit] dc4515: A `frameset` tag inside `template` should be simpl...

Ahmad Saleem noreply at github.com
Mon May 8 23:48:31 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dc45153ce2d1ba0b2f778a5da7c835d99556feb6
      https://github.com/WebKit/WebKit/commit/dc45153ce2d1ba0b2f778a5da7c835d99556feb6
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-05-08 (Mon, 08 May 2023)

  Changed paths:
    A LayoutTests/fast/parser/disable-frameset-ok-flag-inside-template-expected.txt
    A LayoutTests/fast/parser/disable-frameset-ok-flag-inside-template.html
    A LayoutTests/fast/parser/resources/frameset-inside-template.html
    M Source/WebCore/html/parser/HTMLTreeBuilder.cpp

  Log Message:
  -----------
  A `frameset` tag inside `template` should be simply ignored

https://bugs.webkit.org/show_bug.cgi?id=256455

Reviewed by Ryosuke Niwa.

This patch aligns WebKit with Web-Spec [1] and Blink / Chromium.

Merge: https://chromium.googlesource.com/chromium/src/+/93198017327e240584facc073ae5853a1cc78a6c

As stated in the spec [1], `template` tag start token should set framesetOk
flag to false when in in-body/in-head insertion mode.

[1] https://html.spec.whatwg.org/multipage/parsing.html#parsing-main-inbody

* Source/WebCore/html/parser/HTMLTreeBuilder.cpp:
(HTMLTreeBuilder::processTemplateStartTag): As above
* LayoutTests/fast/parser/resources/frameset-inside-template.html: Add Test Case Resource
* LayoutTests/fast/parser/disable-frameset-ok-flag-inside-template.html: Add Test Case
* LayoutTests/fast/parser/disable-frameset-ok-flag-inside-template-expected.txt: Add Test Case Expectation

Canonical link: https://commits.webkit.org/263851@main




More information about the webkit-changes mailing list