[webkit-changes] [WebKit/WebKit] 043404: Fix bug in preload scanner with nested templates

Ahmad Saleem noreply at github.com
Mon May 8 23:46:56 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0434048daa53e9e16f072e710fe8c555eb310813
      https://github.com/WebKit/WebKit/commit/0434048daa53e9e16f072e710fe8c555eb310813
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-05-08 (Mon, 08 May 2023)

  Changed paths:
    A LayoutTests/fast/preloader/image-in-nested-template-expected.txt
    A LayoutTests/fast/preloader/image-in-nested-template.html
    M Source/WebCore/html/parser/HTMLPreloadScanner.cpp

  Log Message:
  -----------
  Fix bug in preload scanner with nested templates

https://bugs.webkit.org/show_bug.cgi?id=256456

Reviewed by Ryosuke Niwa.

This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.

Merge: https://chromium.googlesource.com/chromium/src/+/168fe3ddcae333c7f2073e32b6f9a9f2b343be98

Prior to this patch, the preload scanner would incorrectly count
nested templates, which would cause it to load some resources
that it shouldn't. This patch fixes that bug, and adds tests.

* Source/WebCore/html/parser/HTMLPreloadScanner.cpp:
(TokenPreloadScanner::scan): As above
* LayoutTests/fast/preloader/image-in-nested-template.html: Add Test Case
* LayoutTests/fast/preloader/image-in-nested-template-expected.txt: Add Test Case Expectation

Canonical link: https://commits.webkit.org/263850@main




More information about the webkit-changes mailing list