[webkit-changes] [WebKit/WebKit] 38b868: Web Inspector: Regression (258503 at main) Font featu...

[Razvan Caliman - Apple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 38b868bbbaa50a85247eab0ae0ea58723a803641
      https://github.com/WebKit/WebKit/commit/38b868bbbaa50a85247eab0ae0ea58723a803641
  Author: Razvan Caliman <rcaliman at apple.com>
  Date:   2023-05-08 (Mon, 08 May 2023)

  Changed paths:
    M Source/WebInspectorUI/UserInterface/Views/FontDetailsPanel.js

  Log Message:
  -----------
  Web Inspector: Regression (258503 at main) Font feature property values shown in Font panel are always Normal
https://bugs.webkit.org/show_bug.cgi?id=256364

Reviewed by Patrick Angle.

When relocating code from the `Font` model to the `FontStyles` model
in https://github.com/WebKit/WebKit/pull/8157, we forgot to update
the path to the font styles regular expression pattern,
`WI.Font.SettingPattern` -> `WI.FontStyles.SettingPattern`,
used to match the parts of `font-variant-*` CSS property values.

In absence of a match, the fallback UI string was used,
which is `Normal` for most font feature property values.

* Source/WebInspectorUI/UserInterface/Views/FontDetailsPanel.js:
(WI.FontDetailsPanel.prototype._formatSimpleFeatureValues):
(WI.FontDetailsPanel.prototype._formatLigatureValue):

Canonical link: https://commits.webkit.org/263814@main