[webkit-changes] [WebKit/WebKit] 352b95: AX: reconcile aria-describedby and aria-descriptio...

[Chris Fleizach]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 352b951ab4a8d8e91964eab584ea727b271f7c6e
      https://github.com/WebKit/WebKit/commit/352b951ab4a8d8e91964eab584ea727b271f7c6e
  Author: Chris Fleizach <cfleizach at apple.com>
  Date:   2023-05-08 (Mon, 08 May 2023)

  Changed paths:
    M LayoutTests/accessibility/aria-describedby-on-input.html
    M LayoutTests/accessibility/aria-description-expected.txt
    M LayoutTests/accessibility/aria-description.html
    M LayoutTests/accessibility/custom-elements/describedby-shadow.html
    M LayoutTests/accessibility/custom-elements/describedby.html
    M LayoutTests/accessibility/element-reflection-ariadescribedby.html
    M LayoutTests/accessibility/ios-simulator/figure-element-expected.txt
    M LayoutTests/accessibility/ios-simulator/figure-element.html
    M LayoutTests/accessibility/mac/figure-element-expected.txt
    M LayoutTests/accessibility/mac/figure-element.html
    M LayoutTests/accessibility/text-alternative-calculation-from-unrendered-table.html
    M LayoutTests/accessibility/text-alternative-calculation-hidden-nodes.html
    M LayoutTests/platform/ios/accessibility/aria-describedby-on-input-expected.txt
    A LayoutTests/platform/ios/accessibility/aria-description-expected.txt
    A LayoutTests/platform/mac/accessibility/aria-describedby-on-input-expected.txt
    A LayoutTests/platform/mac/accessibility/aria-description-expected.txt
    A LayoutTests/platform/mac/accessibility/custom-elements/describedby-expected.txt
    A LayoutTests/platform/mac/accessibility/custom-elements/describedby-shadow-expected.txt
    A LayoutTests/platform/mac/accessibility/element-reflection-ariadescribedby-expected.txt
    A LayoutTests/platform/mac/accessibility/text-alternative-calculation-from-unrendered-table-expected.txt
    A LayoutTests/platform/mac/accessibility/text-alternative-calculation-hidden-nodes-expected.txt
    M LayoutTests/platform/wpe/accessibility/aria-description-expected.txt
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm
    M Tools/DumpRenderTree/AccessibilityUIElement.cpp
    M Tools/DumpRenderTree/AccessibilityUIElement.h
    M Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm
    M Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm

  Log Message:
  -----------
  AX: reconcile aria-describedby and aria-description in WebKit
https://bugs.webkit.org/show_bug.cgi?id=255812
rdar://108386295

Reviewed by Andres Gonzalez.

aria-describedby should be equivalent to aria-description (and override it when both are present).
These should map to AXCustomContent with importance of high.

* LayoutTests/accessibility/aria-describedby-on-input.html:
* LayoutTests/accessibility/aria-description-expected.txt:
* LayoutTests/accessibility/aria-description.html:
* LayoutTests/accessibility/custom-elements/describedby-shadow.html:
* LayoutTests/accessibility/custom-elements/describedby.html:
* LayoutTests/accessibility/element-reflection-ariadescribedby.html:
* LayoutTests/accessibility/ios-simulator/figure-element-expected.txt:
* LayoutTests/accessibility/ios-simulator/figure-element.html:
* LayoutTests/accessibility/mac/figure-element-expected.txt:
* LayoutTests/accessibility/mac/figure-element.html:
* LayoutTests/accessibility/text-alternative-calculation-from-unrendered-table.html:
* LayoutTests/accessibility/text-alternative-calculation-hidden-nodes.html:
* LayoutTests/platform/ios/accessibility/aria-describedby-on-input-expected.txt:
* LayoutTests/platform/mac/accessibility/aria-describedby-on-input-expected.txt: Added.
* LayoutTests/platform/mac/accessibility/aria-description-expected.txt: Copied from LayoutTests/accessibility/aria-description-expected.txt.
* LayoutTests/platform/mac/accessibility/custom-elements/describedby-expected.txt: Added.
* LayoutTests/platform/mac/accessibility/custom-elements/describedby-shadow-expected.txt: Added.
* LayoutTests/platform/mac/accessibility/element-reflection-ariadescribedby-expected.txt: Added.
* LayoutTests/platform/mac/accessibility/text-alternative-calculation-from-unrendered-table-expected.txt: Added.
* LayoutTests/platform/mac/accessibility/text-alternative-calculation-hidden-nodes-expected.txt: Added.
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::helpText const):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::extendedDescription const):
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase accessibilityCustomContent]):
* Tools/DumpRenderTree/AccessibilityUIElement.cpp:
(getCustomContentCallback):
(AccessibilityUIElement::getJSClass):
* Tools/DumpRenderTree/AccessibilityUIElement.h:
* Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::customContent const):
* Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::customContent const):

Canonical link: https://commits.webkit.org/263813@main