[webkit-changes] [WebKit/WebKit] e4e4f4: HTMLCanvasElement accesses ImageBufferBackend

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e4e4f40e8fbd6a284baf8ccbda286c2f7f680c56
      https://github.com/WebKit/WebKit/commit/e4e4f40e8fbd6a284baf8ccbda286c2f7f680c56
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-05-08 (Mon, 08 May 2023)

  Changed paths:
    M Source/WebCore/html/HTMLCanvasElement.cpp
    M Source/WebCore/html/HTMLCanvasElement.h

  Log Message:
  -----------
  HTMLCanvasElement accesses ImageBufferBackend
https://bugs.webkit.org/show_bug.cgi?id=255984
rdar://108555582

Reviewed by Matt Woodrow.

Remove the ad-hoc access of ImageBufferBackend in HTMLCanvasElement.

The original code in bug 231163 tried to work around the
case where Canvas was in GPUP but DOM access was in WP, and when
the RemoteImageBufferProxy, ImageBufferIOSurfaceBackend ehad bugs
related to flushing the drawing before external access.

These issues have been worked on now, and it should be safe to remove
the workaround. Also current Cocoa trunk builds are all in different
configuration (full GPUP).

* Source/WebCore/html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint):
(WebCore::HTMLCanvasElement::drawingContext const): Deleted.
* Source/WebCore/html/HTMLCanvasElement.h:
* Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.h:

Canonical link: https://commits.webkit.org/263798@main