[webkit-changes] [WebKit/WebKit] 03ed22: [GStreamer][WebRTC] Outgoing video with odd dimens...

Philippe Normand noreply at github.com
Mon May 8 05:16:44 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 03ed22e40854af5ac798de592c22f7e7c22706ab
      https://github.com/WebKit/WebKit/commit/03ed22e40854af5ac798de592c22f7e7c22706ab
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-05-08 (Mon, 08 May 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.h
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.h

  Log Message:
  -----------
  [GStreamer][WebRTC] Outgoing video with odd dimensions refused by encoder
https://bugs.webkit.org/show_bug.cgi?id=256368

Reviewed by Xabier Rodriguez-Calvar.

Video encoders require a multiple of two frame size. At least x264enc does anyway. This can't easily
be applied in our encoder wrapper, so we do it in the MediaStream source instead.

* Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp:
(WebCore::VideoFrameGStreamer::resizedSample):
(WebCore::VideoFrameGStreamer::resizeTo):
* Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.h:
* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:

Canonical link: https://commits.webkit.org/263797@main




More information about the webkit-changes mailing list