[webkit-changes] [WebKit/WebKit] 0c07f1: [JSC] Make Weak::~Weak inlined

Yusuke Suzuki noreply at github.com
Wed May 3 00:54:58 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0c07f17913190779681015f86a52b642c03303dc
      https://github.com/WebKit/WebKit/commit/0c07f17913190779681015f86a52b642c03303dc
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-05-03 (Wed, 03 May 2023)

  Changed paths:
    M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
    M Source/JavaScriptCore/Sources.txt
    R Source/JavaScriptCore/heap/Weak.cpp
    M Source/JavaScriptCore/heap/Weak.h
    M Source/JavaScriptCore/heap/WeakImpl.h
    M Source/JavaScriptCore/heap/WeakSet.h
    M Source/JavaScriptCore/runtime/ArrayBuffer.h
    M Source/WebCore/bindings/js/ScriptWrappable.h
    M Source/WebCore/bindings/js/ScriptWrappableInlines.h

  Log Message:
  -----------
  [JSC] Make Weak::~Weak inlined
https://bugs.webkit.org/show_bug.cgi?id=256203
rdar://108777077

Reviewed by Mark Lam.

weakClearSlowCase is not inlined while it is super tiny function because it is called from WebCore and
it is defined as JSC's non-inlined function, this is silly. We make Weak::clear inlined function so
that we can make Weak::~Weak fully inlined.

* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
* Source/JavaScriptCore/Sources.txt:
* Source/JavaScriptCore/heap/Weak.cpp: Removed.
* Source/JavaScriptCore/heap/Weak.h:
(JSC::Weak::clear): Deleted.
* Source/JavaScriptCore/heap/WeakImpl.h:
(JSC::WeakImpl::WeakImpl):
(JSC::WeakImpl::clear):
(JSC::Weak<T>::clear):
* Source/JavaScriptCore/heap/WeakSet.h:
(JSC::WeakSet::deallocate):
* Source/JavaScriptCore/runtime/ArrayBuffer.h:
* Source/WebCore/bindings/js/ScriptWrappable.h:
* Source/WebCore/bindings/js/ScriptWrappableInlines.h:

Canonical link: https://commits.webkit.org/263623@main




More information about the webkit-changes mailing list