[webkit-changes] [WebKit/WebKit] 358244: Crashes under SystemPreviewController::loadFailed ...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3582444bb21b9adfe2e203f3b1a843e79a518b3b
      https://github.com/WebKit/WebKit/commit/3582444bb21b9adfe2e203f3b1a843e79a518b3b
  Author: Tim Horton <thorton at apple.com>
  Date:   2023-05-02 (Tue, 02 May 2023)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm
    M Source/WebKit/UIProcess/SystemPreviewController.h

  Log Message:
  -----------
  Crashes under SystemPreviewController::loadFailed after 263479 at main
https://bugs.webkit.org/show_bug.cgi?id=256246
rdar://108826094

Reviewed by Wenson Hsieh.

* Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
* Source/WebKit/UIProcess/SystemPreviewController.h:
Fix a few small issues with 263479 at main:

1) Don't call `cancelPreviewApplicationWithURLs` if we never called
   `beginPreviewApplicationWithURLs`, by keeping track of the current loading state.

2) Don't try to create an array of NSURLs with nil entries.

3) Allow previews by extension in addition to MIME type.

Canonical link: https://commits.webkit.org/263622@main