[webkit-changes] [WebKit/WebKit] c8f286: Rename text-edge to text-box-edge to match the lat...

Tue May 2 15:14:55 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c8f286909017f23b20c9e7df0a37b7908916caff
      https://github.com/WebKit/WebKit/commit/c8f286909017f23b20c9e7df0a37b7908916caff
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-05-02 (Tue, 02 May 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/fast/text/text-box-edge-no-half-leading-simple-expected-mismatch.html
    A LayoutTests/fast/text/text-box-edge-no-half-leading-simple.html
    A LayoutTests/fast/text/text-box-edge-no-half-leading-with-line-height-simple-expected-mismatch.html
    A LayoutTests/fast/text/text-box-edge-no-half-leading-with-line-height-simple.html
    A LayoutTests/fast/text/text-box-edge-property-parsing-expected.txt
    A LayoutTests/fast/text/text-box-edge-property-parsing.html
    A LayoutTests/fast/text/text-box-edge-with-margin-padding-border-simple-expected-mismatch.html
    A LayoutTests/fast/text/text-box-edge-with-margin-padding-border-simple.html
    R LayoutTests/fast/text/text-edge-no-half-leading-simple-expected-mismatch.html
    R LayoutTests/fast/text/text-edge-no-half-leading-simple.html
    R LayoutTests/fast/text/text-edge-no-half-leading-with-line-height-simple-expected-mismatch.html
    R LayoutTests/fast/text/text-edge-no-half-leading-with-line-height-simple.html
    R LayoutTests/fast/text/text-edge-property-parsing-expected.txt
    R LayoutTests/fast/text/text-edge-property-parsing.html
    R LayoutTests/fast/text/text-edge-with-margin-padding-border-simple-expected-mismatch.html
    R LayoutTests/fast/text/text-edge-with-margin-padding-border-simple.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssom-getPropertyValue-common-checks-expected.txt
    M LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M Source/WebCore/Headers.cmake
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/animation/CSSPropertyAnimation.cpp
    M Source/WebCore/css/CSSPrimitiveValueMappings.h
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/CSSValueKeywords.in
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/parser/CSSPropertyParser.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/style/RenderStyle.cpp
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleConstants.cpp
    M Source/WebCore/rendering/style/RenderStyleConstants.h
    M Source/WebCore/rendering/style/StyleRareInheritedData.cpp
    M Source/WebCore/rendering/style/StyleRareInheritedData.h
    A Source/WebCore/rendering/style/StyleTextBoxEdge.h
    R Source/WebCore/rendering/style/StyleTextEdge.h
    M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  -----------
  Rename text-edge to text-box-edge to match the latest spec
https://bugs.webkit.org/show_bug.cgi?id=256190

Reviewed by Tim Nguyen.

See https://www.w3.org/TR/css-inline-3/#text-edges.

* LayoutTests/TestExpectations:
* LayoutTests/fast/text/text-box-edge-no-half-leading-simple-expected-mismatch.html: Renamed from LayoutTests/fast/text/text-edge-no-half-leading-simple.html.
* LayoutTests/fast/text/text-box-edge-no-half-leading-simple.html: Renamed from LayoutTests/fast/text/text-edge-no-half-leading-simple-expected-mismatch.html.
* LayoutTests/fast/text/text-box-edge-no-half-leading-with-line-height-simple-expected-mismatch.html: Renamed from LayoutTests/fast/text/text-edge-no-half-leading-with-line-height-simple-expected-mismatch.html.
* LayoutTests/fast/text/text-box-edge-no-half-leading-with-line-height-simple.html: Renamed from LayoutTests/fast/text/text-edge-no-half-leading-with-line-height-simple.html.
* LayoutTests/fast/text/text-box-edge-property-parsing-expected.txt: Added.
* LayoutTests/fast/text/text-box-edge-property-parsing.html: Added.
* LayoutTests/fast/text/text-box-edge-with-margin-padding-border-simple-expected-mismatch.html: Renamed from LayoutTests/fast/text/text-edge-with-margin-padding-border-simple-expected-mismatch.html.
* LayoutTests/fast/text/text-box-edge-with-margin-padding-border-simple.html: Renamed from LayoutTests/fast/text/text-edge-with-margin-padding-border-simple.html.
* LayoutTests/fast/text/text-edge-property-parsing-expected.txt: Removed.
* LayoutTests/fast/text/text-edge-property-parsing.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssom-getPropertyValue-common-checks-expected.txt:
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::toCSSValueID):
(WebCore::fromCSSValueID):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::valueForTextBoxEdge):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
(WebCore::valueForTextEdge): Deleted.
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::initialValueForLonghand):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeTextBoxEdge):
(WebCore::CSSPropertyParserHelpers::consumeTextEdge): Deleted.
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:
(WebCore::Layout::InlineLevelBox::textBoxEdge const):
(WebCore::Layout::m_style):
(WebCore::Layout::InlineLevelBox::textEdge const): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::isTextBoxEdgeLeading):
(WebCore::Layout::ascentAndDescentWithTextBoxEdgeForInlineBox):
(WebCore::Layout::LineBoxBuilder::enclosingAscentDescentWithFallbackFonts const):
(WebCore::Layout::LineBoxBuilder::setLayoutBoundsForInlineBox const):
(WebCore::Layout::LineBoxBuilder::setVerticalPropertiesForInlineLevelBox const):
(WebCore::Layout::LineBoxBuilder::computeLineBoxGeometry const):
(WebCore::Layout::isTextEdgeLeading): Deleted.
(WebCore::Layout::ascentAndDescentWithTextEdgeForInlineBox): Deleted.
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::TextBoxTrimmer::setTextBoxTrimForSubtree):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::textBoxEdge const):
(WebCore::RenderStyle::setTextBoxEdge):
(WebCore::RenderStyle::initialTextBoxEdge):
(WebCore::RenderStyle::textEdge const): Deleted.
(WebCore::RenderStyle::setTextEdge): Deleted.
(WebCore::RenderStyle::initialTextEdge): Deleted.
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
* Source/WebCore/rendering/style/RenderStyleConstants.h:
* Source/WebCore/rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):
* Source/WebCore/rendering/style/StyleRareInheritedData.h:
* Source/WebCore/rendering/style/StyleTextBoxEdge.h: Renamed from Source/WebCore/rendering/style/StyleTextEdge.h.
(WebCore::operator==):
(WebCore::operator!=):
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertTextBoxEdge):
(WebCore::Style::BuilderConverter::convertTextEdge): Deleted.

Canonical link: https://commits.webkit.org/263612@main