[webkit-changes] [WebKit/WebKit] 0d333b: REGRESSION (macOS Ventura 13.3, iOS 16.4) fast/shr...
Tim Horton
noreply at github.com
Tue May 2 15:10:54 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0d333bfa0c2086827f7a817b05e9998e6c12827d
https://github.com/WebKit/WebKit/commit/0d333bfa0c2086827f7a817b05e9998e6c12827d
Author: Tim Horton <timothy_horton at apple.com>
Date: 2023-05-02 (Tue, 02 May 2023)
Changed paths:
M LayoutTests/platform/ios-wk2/TestExpectations
M LayoutTests/platform/mac-wk1/TestExpectations
M LayoutTests/platform/mac/TestExpectations
M Source/WebCore/platform/graphics/PathUtilities.cpp
Log Message:
-----------
REGRESSION (macOS Ventura 13.3, iOS 16.4) fast/shrink-wrap/rect-shrink-wrap.html is a constant ImageOnlyFailure
https://bugs.webkit.org/show_bug.cgi?id=256114
rdar://108682116
Reviewed by Wenson Hsieh.
* LayoutTests/platform/ios-wk2/TestExpectations:
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:
De-ImageOnlyFailure this test.
* Source/WebCore/platform/graphics/PathUtilities.cpp:
(WebCore::PathUtilities::pathsWithShrinkWrappedRects):
When clamping the shrink-wrap radius to half the length of each edge, if we
had accumulated floating point error in the X coordinate, we could end up
choosing the wrong axis to clamp to.
Instead of choosing one axis, just grab the length of the vector and use that.
It's always axis-aligned, anyway, barring floating point error.
(WebCore::adjustedRadiiForHuggingCurve):
(WebCore::PathUtilities::pathWithShrinkWrappedRectsForOutline):
(WebCore::adjustedtRadiiForHuggingCurve): Deleted.
Fix a typo.
Canonical link: https://commits.webkit.org/263611@main
More information about the webkit-changes
mailing list