[webkit-changes] [WebKit/WebKit] 890b60: [macOS] Declare notification names observed by Web...

aestes noreply at github.com
Tue May 2 09:37:16 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 890b606d3b29fa00a87b9b92645df4e2c5c836de
      https://github.com/WebKit/WebKit/commit/890b606d3b29fa00a87b9b92645df4e2c5c836de
  Author: Andy Estes <aestes at apple.com>
  Date:   2023-05-02 (Tue, 02 May 2023)

  Changed paths:
    M Source/WebCore/PAL/pal/spi/mac/NSWindowSPI.h
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm
    M Source/WebKitLegacy/mac/WebView/WebViewData.mm

  Log Message:
  -----------
  [macOS] Declare notification names observed by WebKit in NSWindowSPI.h
https://bugs.webkit.org/show_bug.cgi?id=256184

Reviewed by Wenson Hsieh.

Ensured `NSWindowDidOrderOffScreenNotification`, `NSWindowDidOrderOnScreenNotification`, and
`_NSWindowDidChangeContentsHostedInLayerSurfaceNotification` are declared in NSWindowSPI.h then
used those constants instead of string literals in WebViewData.m and WebViewImpl.m. Note that
`NSWindowDidOrderOnScreenNotification` is defined to `@"_NSWindowDidBecomeVisible"` in AppKit.

* Source/WebCore/PAL/pal/spi/mac/NSWindowSPI.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(-[WKWindowVisibilityObserver startObserving:]):
(-[WKWindowVisibilityObserver stopObserving:]):
* Source/WebKitLegacy/mac/WebView/WebViewData.mm:
(-[WebWindowVisibilityObserver startObserving:]):
(-[WebWindowVisibilityObserver stopObserving:]):

Canonical link: https://commits.webkit.org/263592@main




More information about the webkit-changes mailing list