[webkit-changes] [WebKit/WebKit] ccccc5: Fix debug build with assertions disabled

Alex Christensen noreply at github.com
Tue May 2 09:20:00 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ccccc554960d2ca04f3a7ae5c9dac542682af585
      https://github.com/WebKit/WebKit/commit/ccccc554960d2ca04f3a7ae5c9dac542682af585
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-05-02 (Tue, 02 May 2023)

  Changed paths:
    M Source/JavaScriptCore/bytecode/CodeBlock.h
    M Source/WTF/wtf/RefCountedLeakCounter.cpp
    M Source/WTF/wtf/RefCountedLeakCounter.h
    M Source/WebCore/animation/KeyframeEffect.cpp
    M Source/WebCore/layout/Verification.cpp
    M Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp
    M Source/WebCore/page/LocalFrameViewLayoutContext.cpp
    M Source/WebCore/platform/animation/AcceleratedEffect.cpp
    M Source/WebCore/platform/mediastream/MediaConstraints.h
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm

  Log Message:
  -----------
  Fix debug build with assertions disabled
https://bugs.webkit.org/show_bug.cgi?id=256199
rdar://108773614

Reviewed by Chris Dumez.

There are some inconsistent uses of NDEBUG, LOG_DISABLED, and ASSERT_ENABLED.
If I change the definition of ASSERT_ENABLED to always be 0, this fixes the debug build.

* Source/JavaScriptCore/bytecode/CodeBlock.h:
* Source/WTF/wtf/RefCountedLeakCounter.cpp:
(WTF::RefCountedLeakCounter::RefCountedLeakCounter):
* Source/WTF/wtf/RefCountedLeakCounter.h:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::acceleratedPropertyDidChange):
* Source/WebCore/layout/Verification.cpp:
* Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
* Source/WebCore/page/LocalFrameViewLayoutContext.cpp:
(WebCore::LocalFrameViewLayoutContext::layoutUsingFormattingContext):
* Source/WebCore/platform/animation/AcceleratedEffect.cpp:
(WebCore::acceleratedPropertyFromCSSProperty):
* Source/WebCore/platform/mediastream/MediaConstraints.h:
(WebCore::FlattenedConstraint::iterator::iterator):
(WebCore::FlattenedConstraint::iterator::operator++):
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticator::continueMakeCredentialAfterUserVerification):

Canonical link: https://commits.webkit.org/263591@main




More information about the webkit-changes mailing list